Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line styling not recognized when using ELK #340

Open
StephanPirnbaum opened this issue Feb 28, 2024 · 2 comments
Open

Line styling not recognized when using ELK #340

StephanPirnbaum opened this issue Feb 28, 2024 · 2 comments
Labels
forum/plantuml Issue reported to forum/plantuml, wait for final solution

Comments

@StephanPirnbaum
Copy link

I'm using C4-PlantUML with ELK, as it regularly produces better outputs.
However, I ran into an issue when using e.g. lineColor or lineStyle.

In the following example, the relation defined using standard PlantUML syntax is correctly rendered, whereas using the C4-PlantUML it is not.

@startuml
!include <C4/C4_Component>
!pragma layout elk

AddRelTag("DEF", $legendText="Java-Abhängigkeit", $lineColor = "#blue", $lineStyle = DottedLine())

Component(A, "A")

Component(B, "B")

A -[#orange,dashed]-> B

Rel(A, B, "Test", $tags="DEF")
@enduml

This leads me to the conclusion that ELK itself has no issues with styling lines (which would have had me wonder, tbh).

When not using ELK, the example is working, however.

@startuml
!include <C4/C4_Component>

AddRelTag("DEF", $legendText="Java-Abhängigkeit", $lineColor = "#blue", $lineStyle = DottedLine())

Component(A, "A")

Component(B, "B")

A -[#orange,dashed]-> B

Rel(A, B, "Test", $tags="DEF")
@enduml

For me, that looks like an issue of the combination C4-PlantUML syntax and ELK.

@kirchsth
Copy link
Contributor

Hi @StephanPirnbaum,

thank you for the finding, but I think your conclusion is wrong. I think it is elk related, I can reproduce the problem without C4 too. Samples see below.

I entered a bug in the PlantUML forum

BR Helmut

@StephanPirnbaum
Copy link
Author

Hi @kirchsth

thank you for the fast investigation and reply. You're right, I was not considering using skinparam which would explain the difference to my example. I can confirm your conclusion.

@kirchsth kirchsth changed the title Styling not recognized when using ELK Line styling not recognized when using ELK Mar 9, 2024
@kirchsth kirchsth added the forum/plantuml Issue reported to forum/plantuml, wait for final solution label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forum/plantuml Issue reported to forum/plantuml, wait for final solution
Projects
None yet
Development

No branches or pull requests

2 participants