Skip to content
This repository has been archived by the owner on Jul 19, 2022. It is now read-only.

Multiple execution of felicette fails, and the generated images are incorrect #17

Open
whiteglobe opened this issue Jul 27, 2020 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@whiteglobe
Copy link

if we try to run process in two terminal one of them process is " killed" error and image quality for zooming not god

@plant99
Copy link
Owner

plant99 commented Jul 27, 2020

Hi @whiteglobe , thanks for pointing it out. I just cross-checked and could reproduce this issue.

A temporary fix for this is to restrict number of running 'felicette' processes to 1 using a simple file-based lock

@plant99 plant99 added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 27, 2020
@plant99 plant99 changed the title multi Handel issu Multiple execution of felicette fails, and the generated image incorrect Jul 27, 2020
@Abhijnan-Bajpai
Copy link

I understood the solution you're asking to implement, but where exactly do we implement this in the code-base?

@plant99 plant99 changed the title Multiple execution of felicette fails, and the generated image incorrect Multiple execution of felicette fails, and the generated images are incorrect Jul 28, 2020
@plant99
Copy link
Owner

plant99 commented Jul 28, 2020

Hi @Abhijnan-Bajpai , acquire the file-lock here, and release the file-lock here, and here (since CLI can exit this way as well).

The util functions to create/remove a file-lock should be in felicette/sys_utils.py. Is that clear, do you need more help?

Here are some pointers

Also a suggested filepath for the file-lock would be os.path.join(landsat_item._data["id"], 'lockfile'), since felicette running with 1+ instances on different 'locations' work just fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants