Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Quart #134

Open
Sytten opened this issue Sep 21, 2019 · 4 comments
Open

Compatibility with Quart #134

Sytten opened this issue Sep 21, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@Sytten
Copy link

Sytten commented Sep 21, 2019

Since the future is ASGI (Django announced support for v3), it would be a good idea for flask-rebar to support at least Quart to provide a smoother transition.

@RookieRick
Copy link
Contributor

Color me intrigued 😄 Haven't had much time for non-firefighting Flask-Rebar stuff of late but at first glance this does seem like something worth considering. We'd have to figure out how we deal with version restrictions (Quart requiring Python 3.7+). Should probably also be jettisoning support for Py2 as it reaches end of life so tagging this one as a "v2.0" for now and perhaps we can tackle those at the same time.

@RookieRick RookieRick added the v2.0 breaking changes for next major release label Sep 27, 2019
@airstandley
Copy link
Contributor

Hey Sytten,
Thanks for the suggestion!

I think it's worth noting that we have fairly strongly branded flask-rebar as a Flask based library (since it's in the name and all 😄) and werkzeug/Flask appear to have committed to supporting ASGI eventually. (pallets/werkzeug#1322)

That said it definitely seems like there are a ton of barriers for that process.
If we can support Quarts in the mean time without breaking Flask support, that seems like a win to me!

(Side note: Wait Django finally announced official support for ASGI?!?! I'm so happy 💟 . I still have nightmares about getting django-channels playing nice....)

@RookieRick
Copy link
Contributor

🤣 Yeah the name thing did cross my mind too

@Sytten
Copy link
Author

Sytten commented Sep 29, 2019

ASGI is eating the world :)
The good thing with Quart is that it's API compatible with Flask (thats why I suggested this framework) and most library are already working with it. I think the only thing we can't use is current_app.

@RookieRick RookieRick added enhancement New feature or request and removed v2.0 breaking changes for next major release labels Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants