Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Switch to ASP.NET Core and new SDK style projects #536

Open
Cheesebaron opened this issue Nov 21, 2018 · 7 comments
Open

Switch to ASP.NET Core and new SDK style projects #536

Cheesebaron opened this issue Nov 21, 2018 · 7 comments

Comments

@Cheesebaron
Copy link
Member

I would love for us to migrate to ASP.NET Core and SDK style projects.

  • One big advantage would be that new authors do not need to mess with the csproj file when adding their blog.
  • Also new and shiny ASP.NET Core which can be deployed anywhere!

@ghuntley is the upstream Firehose project still maintained?

@jamesmontemagno
Copy link
Member

It can be done as I use blog monster stuff on www.soundbite.fm, but I needed to pull in the code. I sent a PR uglybugger/BlogMonster#3 but it isn't maintained :( maybe they will let us take it over?

@Cheesebaron
Copy link
Member Author

@jamesmontemagno I've been working a bit on a solution, which does not use the BlogMonster parts a couple of times. It should be fairly simple to ditch the BlogMonster dependency, the trickiest part is to merge all the feeds. I think I still have a branch somewhere I can publish.

@jamesmontemagno
Copy link
Member

I think we can re-use all of blog monster as i use it already, but maybe we just fork it with my changes and add it as a submodule?

@saamerm
Copy link
Contributor

saamerm commented May 17, 2020

Has anyone tried to switch this to use .NET Core? I hopped onto a make to look into the existing tools from here (https://docs.microsoft.com/en-us/dotnet/core/porting/) for switching. I tried the two ways suggested, but I got the same error as you can see:

  • The Portability Analyzer says that this solution uses System.Web and so we are "a while away from porting"
  • Then I tried using try-convert, and they mentioned that "Firehose.Web.csproj is a legacy web project and/or reference System.Web."

I tried to looking into how it can not depend on System.Web but it seemed really difficult to do, and I was getting the weirdest issues using the same solution:

  • I created a new template based .Net core MVC Web Solution in VS 2019 that I was able to build and view in my browser. And then I tried to mimic the Startup.cs file into the Firehose.Web project, but I was getting errors where I wasn't able to access certain functions and classes, even though I had installed the same Nuget package as the template.

The solution after spending several hours looking into this, to me seems like creating a new project from the ground and porting things over. Any one have any ideas, or already started on some work for migration?

(PS: It will be great once it's on .NET Core, so developers can just use a Mac to build the SLN)

@Cheesebaron , @jamesmontemagno

@saamerm
Copy link
Contributor

saamerm commented Jul 20, 2020

@Cheesebaron do you know if we have a branch with this in progress?

@Cheesebaron
Copy link
Member Author

@saamerm there is no one working on this.

@saamerm
Copy link
Contributor

saamerm commented Mar 20, 2021

Since in my last attempt, I wasn't able to migrate from the existing project, this time I decided to create a new solution and bring in the changes piece-by-piece. In the repo, you can see the commits to understand the route I took to come up with the possible solution.
I added details about my attempt, along with a GIF, and issues I faced over here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants