API: Add submission with non existing sectionId results Fatal Error

[defstat]

Describe the bug
If a user tries to call the add endpoint of the submission API providing a sectionId that can't be found in the DB, a fatal error is produced

To Reproduce
Steps to reproduce the behavior:
POST http://localhost:8000/index.php/publicknowledge/api/v1/submissions with following data

"commentsForTheEditors": "test api insert",
"locale": "en_US",
"sectionId": 0,
"userGroupId": 0

What application are you using?
OJS, OMP or OPS version 3.4

Additional information
PKPSubmissionHandler => add function does not check if the $section = Repo::section()->get($sectionId, $context->getId()); is returning a valid section entity. Should check and add a validation error.

---

PRs

Branch stable-3_4_0
PKP-LIB: #9472
OJS: pkp/ojs#4192 TESTS ONLY

Branch main
PKP-LIB: #9473
OMP: pkp/omp#1526 TESTS ONLY

[defstat]

@asmecher I have added PRs for this issue for review.

[asmecher]

@defstat, will this work with OMP, where series are optional?

[defstat]

@defstat, will this work with OMP, where series are optional?

@asmecher given that the section related code is already in place at the PKP-LIB level here, OMP is already taken into account.

The $params[$sectionIdPropName] will not be set if series is not defined, thus not taking into account the section related code. Do you have something else in mind for this?

[asmecher]

That makes sense, @defstat, thanks. I've merged to main but as I'm just about to release from stable-3_4_0 I'd rather not make a last-minute merge there unless it's a bug actually causing trouble in the wild. I'd be open to either merging to stable-3_4_0 after this next release, or just leaving it as is. Do you have a preference?

[defstat]

That makes sense, @defstat, thanks. I've merged to main but as I'm just about to release from stable-3_4_0 I'd rather not make a last-minute merge there unless it's a bug actually causing trouble in the wild. I'd be open to either merging to stable-3_4_0 after this next release, or just leaving it as is. Do you have a preference?

Ι have no strong opinion on that. It seems that this is not widely reported, so we could leave it unmerged for the stable branch and revisit it if a related issue/need comes up

[asmecher]

Makes sense to me, thanks!