Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove calls to CDN copies of style/script dependencies #785

Open
NateWr opened this issue Jun 28, 2021 · 1 comment
Open

Remove calls to CDN copies of style/script dependencies #785

NateWr opened this issue Jun 28, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@NateWr
Copy link
Member

NateWr commented Jun 28, 2021

The script, style and font dependencies used in the docs hub should be hosted locally, so that user's visiting our docs hub do not have their request details sent to a third-party server.
@NateWr NateWr added the enhancement New feature or request label Jun 28, 2021
NateWr added a commit to NateWr/pkp-docs that referenced this issue Jun 28, 2021
@NateWr
pkp#785 Use local copies of script, font and style files instead of CDN
7060149
@NateWr
Copy link
Member Author

NateWr commented Jun 28, 2021

This PR removes the call to a CDN for the main assets. There are still some calls to google fonts in the REST API and UI Library documentation. I can remove these but it will take a little more time.

PR:
#786

NateWr added a commit to NateWr/pkp-docs that referenced this issue Jun 30, 2021
@NateWr
pkp#785 Fix use of local fonts
a5186d2
kaitlinnewson added a commit that referenced this issue Jul 6, 2021
@kaitlinnewson
Merge pull request #786 from NateWr/i785_cdn
bd41497 
#785 Use local copies of script, font and style files instead of CDN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NateWr