Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining missing foreign key declarations #8333

Open
4 of 11 tasks
asmecher opened this issue Oct 14, 2022 · 4 comments · May be fixed by #9076, pkp/ojs#3946, pkp/omp#1423 or pkp/ops#543
Open
4 of 11 tasks

Fix remaining missing foreign key declarations #8333

asmecher opened this issue Oct 14, 2022 · 4 comments · May be fixed by #9076, pkp/ojs#3946, pkp/omp#1423 or pkp/ops#543
Assignees
@jonasraoni @pkp-dev-infrastructure
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone
3.5.0 LTS

Comments

@asmecher
Copy link
Member

asmecher commented Oct 14, 2022 •
edited by jonasraoni

This issue is a continuation of #6093.

The remaining missing foreign key constraints will require some code changes to move away from the use of 0 as a reserved case.

  • lib/pkp/classes/migration/install/CommonMigration.php:
    • site.redirect
    • plugin_settings.context_id (uses 0 for site-wide)
    • notifications.context_id (uses 0 for site-wide)
    • notifications.user_id (uses 0 for "anyone" IIRC)
  • lib/pkp/classes/migration/install/LogMigration.php:
    • email_log.sender_id (uses 0 for "nobody in particular")
  • lib/pkp/classes/migration/install/MetadataMigration.php:
    • filters.context_id (uses 0 for site-wide)
    • filters.parent_filter_id (uses 0 for none)
  • lib/pkp/classes/migration/install/NavigationMenusMigration.php:
    • navigation_menus.context_id (0 used for site-wide)
    • navigation_menu_items.context_id (0 used for site-wide)
    • navigation_menu_items_assignments.parent_id (0 apparently used for none, even though the field appears nullable)
  • lib/pkp/classes/migration/install/classes/RolesAndUserGroupsMigration.php:
    • user_groups.context_id (0 used for side-wide)

Some of these areas are slated for rewriting, so this work may be a lower priority than the rewrite.

It makes sense to keep the email_log even when a sender (user) is deleted, but it's probably needed to review GDPR (e.g. right to be forgotten), as the email might keep personal data.
@asmecher asmecher added the Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. label Oct 14, 2022
@asmecher asmecher added this to the 3.5 milestone Oct 14, 2022
@asmecher asmecher mentioned this issue Oct 14, 2022
Closed
39 tasks
This was referenced Jun 7, 2023
Closed
Open
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jun 7, 2023
@jonasraoni
pkp#8333 Added missing foreign keys
a815486
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jun 7, 2023
@jonasraoni
pkp#8333 Updated code to consider the possibility of having NULL inst…
0f045fc 
…ead of 0
@jonasraoni jonasraoni linked a pull request Jun 7, 2023 that will close this issue
Feature/main/8333 Add remaining FKs #9076
Open
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jun 7, 2023
@jonasraoni
pkp/pkp-lib#8333 Added migration to create extra foreign keys
f7d2436
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jun 7, 2023
@jonasraoni
pkp/pkp-lib#8333 Submodule update ##jonasraoni/bugfix/main/8333-add-r…
4efb7cb 
…emaining-fks##
@jonasraoni jonasraoni linked a pull request Jun 7, 2023 that will close this issue
Feature/main/8333 Add remaining FKs pkp/ojs#3946
Open
jonasraoni added a commit to jonasraoni/omp that referenced this issue Jun 7, 2023
@jonasraoni
pkp/pkp-lib#8333 Added migration to create extra foreign keys
6613b01
jonasraoni added a commit to jonasraoni/omp that referenced this issue Jun 7, 2023
@jonasraoni
pkp/pkp-lib#8333 Submodule update ##jonasraoni/feature/main/8333-add-…
1bf7619 
…remaining-fks##
@jonasraoni jonasraoni linked a pull request Jun 7, 2023 that will close this issue
Feature/main/8333 Add remaining FKs pkp/omp#1423
Open
jonasraoni added a commit to jonasraoni/ops that referenced this issue Jun 7, 2023
@jonasraoni
pkp/pkp-lib#8333 Added migration to create extra foreign keys
fdca08c
jonasraoni added a commit to jonasraoni/ops that referenced this issue Jun 7, 2023
@jonasraoni
pkp/pkp-lib#8333 Submodule update ##jonasraoni/feature/main/8333-add-…
436fa36 
…remaining-fks##
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jun 7, 2023
@jonasraoni
pkp/pkp-lib#8333 Submodule update ##jonasraoni/feature/main/8333-add-…
f505fb2 
…remaining-fks##
@jonasraoni jonasraoni linked a pull request Jun 7, 2023 that will close this issue
Bugfix/main/9069 migration issues pkp/ops#540
Merged
@jonasraoni
Copy link
Contributor

I've updated the issue description (added the missing user_groups.context_id and marked others as done), and created initial PRs from detached commits of another issue.

jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jun 8, 2023
@jonasraoni
pkp#9069 Updated cleanup to consider a database without the foreign k…
1ea0c97 
…eys from pkp#8333
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jun 8, 2023
@jonasraoni
pkp#9069 Updated cleanup to consider a database without the foreign k…
4267d4f 
…eys from pkp#8333
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jun 8, 2023
@jonasraoni
pkp#9069 Updated cleanup to consider a database without the foreign k…
b1ba672 
…eys from pkp#8333
@asmecher asmecher mentioned this issue Jun 9, 2023
Merged
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jun 9, 2023
@jonasraoni
pkp#9069 Delegated cleanup of future foreign keys to pkp#8333
3a3de8b
asmecher pushed a commit that referenced this issue Jun 9, 2023
@jonasraoni
Bugfix/main/9069 migration issues (#9071)
e733429 
* #9069 Added missing pre-foreign key cleanups

* #9069 Organized the migration code

* #9069 Added automated code while keeping the customizations

* #9069 Added code to consider the dependencies when running the entity cleanup

* #9069 Added code to ignore a couple of special values, which will be handled by later migrations

* #9069 Added code to dynamically ignore nonexistent entities (review_*)

* #9069 Moved cleanup of notifications.user_id to the foreign key migration and fixed typo

* #9069 Added code to drop existing foreign keys

* #9069 Updated cleanup to consider a database without the foreign keys from #8333

* #9069 Delegated cleanup of future foreign keys to #8333
@jonasraoni jonasraoni reopened this Jun 9, 2023
@jonasraoni jonasraoni removed a link to a pull request Jun 9, 2023
Bugfix/main/9069 migration issues pkp/ops#540
Merged
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jun 9, 2023
@jonasraoni
pkp#8333 Added missing foreign keys
e5abc3c
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jun 9, 2023
@jonasraoni
pkp#8333 Updated code to consider the possibility of having NULL inst…
b42e1b1 
…ead of 0
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jun 9, 2023
@jonasraoni
pkp#8333 Added cleanup code
4805a12
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jun 9, 2023
@jonasraoni
pkp#8333 Moved migration file
a34b317
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jun 9, 2023
@jonasraoni
pkp/pkp-lib#8333 Added migration to create extra foreign keys
406b4f2
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jun 9, 2023
@jonasraoni
pkp/pkp-lib#8333 Moved migration file
b55014a
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Jun 9, 2023
@jonasraoni
pkp/pkp-lib#8333 Submodule update ##jonasraoni/feature/main/8333-add-…
977a9e8 
…remaining-fks##
jonasraoni added a commit to jonasraoni/omp that referenced this issue Jun 9, 2023
@jonasraoni
pkp/pkp-lib#8333 Added migration to create extra foreign keys
5e5c207
jonasraoni added a commit to jonasraoni/omp that referenced this issue Jun 9, 2023
@jonasraoni
pkp/pkp-lib#8333 Moved migration file
d7c7dfd
jonasraoni added a commit to jonasraoni/omp that referenced this issue Jun 9, 2023
@jonasraoni
pkp/pkp-lib#8333 Submodule update ##jonasraoni/feature/main/8333-add-…
79ff391 
…remaining-fks##
jonasraoni added a commit to jonasraoni/ops that referenced this issue Jun 9, 2023
@jonasraoni
pkp/pkp-lib#8333 Moved migration file
ced8a6d
jonasraoni added a commit to jonasraoni/ops that referenced this issue Jun 9, 2023
@jonasraoni
pkp/pkp-lib#8333 Submodule update ##jonasraoni/feature/main/8333-add-…
132a9f2 
…remaining-fks##
@jonasraoni jonasraoni linked a pull request Jun 9, 2023 that will close this issue
Feature/main/8333 add remaining fks pkp/ops#543
Open
@jonasraoni jonasraoni self-assigned this Jun 29, 2023
@jonasraoni
Copy link
Contributor

Added the site.redirect field, I think it's also better to get it renamed to redirect_context_id.

@jonasraoni jonasraoni mentioned this issue May 20, 2024
Closed
6 tasks
@asmecher
Copy link
Member Author

@jonasraoni, can you dust off any remaining PRs here and summarize?

@jonasraoni
Copy link
Contributor

Yep, I've got a couple of PRs to dust off, I'll add this one to the list 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonasraoni jonasraoni

@pkp-dev-infrastructure pkp-dev-infrastructure

Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
None yet
Milestone
3.5.0 LTS
3 participants
@asmecher @jonasraoni @pkp-dev-infrastructure