Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AttributeError exception due to backward incompatible change in Pillow 10.0.0 #142

Open
pieqq opened this issue Jul 12, 2023 · 2 comments · May be fixed by #143
Open

AttributeError exception due to backward incompatible change in Pillow 10.0.0 #142

pieqq opened this issue Jul 12, 2023 · 2 comments · May be fixed by #143

Comments

@pieqq
Copy link

pieqq commented Jul 12, 2023

Hello! I discovered your super handy project while trying to print labels on a Brother QL-800 from Linux. Thanks a lot for the time you spent developing this solution, it's very handy!

I installed the program by following the instructions, but ran into this problem:

 brother_ql -b pyusb -m QL-800 -p usb://0x04f9:0x209b print -l 12 ../202306-31748.png 
deprecation warning: brother_ql.devicedependent is deprecated and will be removed in a future release
Traceback (most recent call last):
  File "/home/u/ql800/venv/bin/brother_ql", line 8, in <module>
    sys.exit(cli())
  File "/home/u/ql800/venv/lib/python3.8/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/home/u/ql800/venv/lib/python3.8/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/home/u/ql800/venv/lib/python3.8/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/u/ql800/venv/lib/python3.8/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/u/ql800/venv/lib/python3.8/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/home/u/ql800/venv/lib/python3.8/site-packages/click/decorators.py", line 34, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/u/ql800/venv/lib/python3.8/site-packages/brother_ql/cli.py", line 146, in print_cmd
    instructions = convert(qlr=qlr, **kwargs)
  File "/home/u/ql800/venv/lib/python3.8/site-packages/brother_ql/conversion.py", line 112, in convert
    im = im.resize((dots_printable[0], hsize), Image.ANTIALIAS)
AttributeError: module 'PIL.Image' has no attribute 'ANTIALIAS'

This is caused by Pillow 10.0.0 which removed ANTIALIAS.

An easy fix for me was to force the installation of the previous version of Pillow, 9.5.0:

pip install --force-reinstall -v "Pillow==9.5.0"

then everything was good.

Two ways to fix this behavior:

  1. Update the code (conversion.py) to use a different method as explained in the Pillow 10.0.0 changelog
  2. Update the setup.py file to fix the Pillow version to 9.x.

Let me know what would be the preferred solution, I can probably help to implement this.

Cheers,
@Th00z Th00z linked a pull request Aug 30, 2023 that will close this issue
Open
@Emily3403 Emily3403 mentioned this issue Sep 4, 2023
Open
@xtlc
Copy link

xtlc commented Oct 9, 2023 •
edited

You can simply add:

from pkg_resources import parse_version
if parse_version(Image.__version__)>=parse_version('10.0.0'):
    Image.ANTIALIAS=Image.LANCZOS

after the line
from PIL import Image
In the conversion.py file of the brother_ql library.

@FriedrichFroebel
Copy link

Using pkg_resources will only work on Python < 3.12 by default due to dropping setuptools from the default packages in a virtual environment. The alternative is to require and use the packaging package or to just replace the usage of the old way and require Python > 3.7 (Python <= 3.7 are EOL anyway).

tback added a commit to tback/brother_ql that referenced this issue Nov 2, 2023
@tback
[fix] "Pillow renamed ANTIALIAS to LANCZOS"
8a24e78 
fixes pklaus#142
@tback tback mentioned this issue Nov 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@pieqq @FriedrichFroebel @xtlc