Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forecast bars contrast is too low in light mode #142

Open
3 tasks done
noiob opened this issue Jan 19, 2023 · 5 comments
Open
3 tasks done

Forecast bars contrast is too low in light mode #142

noiob opened this issue Jan 19, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@noiob
Copy link

noiob commented Jan 19, 2023

Checklist:

  • I updated to the latest version available
  • I cleared the cache of my browser
  • I read the FAQ and the issue I'm having was not mentioned there.

Release with the issue:
1.0.10

Last working release (if known):
n.a.

Browser and Operating System:
n.a.

Description of problem:
The contrast between the forecast bar foreground and background is too low when the background is white. Ideally I'd like to have no background at all, since I'm trying to use the card on an e-Ink display.
grafik

Javascript errors shown in the web inspector (if applicable):
n.a
Additional information:
I have deficient color vision so if it looks fine to you, consider making the card more accessible to colorblind people anyways

@noiob noiob added the bug Something isn't working label Jan 19, 2023
@pkissling
Copy link
Owner

thanks for reporting the issue. you have a very valid point. i never used the card with white background. will have a look on how to fix the issue shortly.

@Watison
Copy link

Watison commented Feb 18, 2023

Hey @pkissling, can I asked what are the colour hex values and corresponding temps you’ve used? I’d like to match the rest of my theme to them. I’d suggest a new feature to change the colours aka mini-graph-card, but I like them as they are.

@pkissling
Copy link
Owner

hi there, sorry that i haven't found the time yet to work on this issue.
colors can be found here: https://github.com/pkissling/clock-weather-card/blob/master/src/clock-weather-card.ts#L48
key is the temperature in Celsius, value the corresponding RGB color

@noiob
Copy link
Author

noiob commented Feb 18, 2023

I worked around the issue for myself by removing the background and adding a bunch of CSS filters to improve contrast and saturation using card-mod. I'll share it here in case someone is interested, note that it'll look a bit weird on an LCD, but it works well for my color E-Ink panel

card_mod:
  style: |
    .card-content {
      padding: 0 8px !important;
    }
    forecast-temperature-bar-background {
      display: none;
    }
    forecast-temperature-bar {
      filter: brightness(80%) saturate(200%) contrast(200%);
    }
    forecast-icon {
      filter: saturate(200%) contrast(200%) brightness(60%);
    }

@airmaxx
Copy link

airmaxx commented Mar 7, 2023

Great idea with card_mod. I've added one entry so that the main icon for gets also updated.

clock-weather-card-today-left {
  filter: saturate(200%) contrast(200%) brightness(60%);
}

@pkissling pkissling added enhancement New feature or request and removed bug Something isn't working labels Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants