Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkenv invariant assertion invalid with duplicate unicode.org packages.= #988

Open
jhheider opened this issue Mar 14, 2024 · 1 comment · May be fixed by #989
Open

mkenv invariant assertion invalid with duplicate unicode.org packages.= #988

jhheider opened this issue Mar 14, 2024 · 1 comment · May be fixed by #989

Comments

@jhheider
Copy link
Contributor 

          Eeeeenteresting. I can guess exactly why:

The error comes from here:

pkgx/src/prefab/construct-env.ts

Lines 38 to 40 in 104affb

async function mkenv({installations}: {installations: Installation[]}) {
const projects = new Set(installations.map(x => x.pkg.project))
console.assert(projects.size == installations.length, "pkgx: env is being duped")

And as of this PR: pkgxdev/libpkgx#61, on January 27th, libpkgx allows multiple versions of unicode in the environment, specifically to deal with postgresql requiring v73 and most of our other packages built for v71. So, it is both the case that the assertion is correct, and the behavior is also correct.

Due to that PR, the assertion is outdated, since we can, now, have more distinct packages than unique packages. So, good find.

Originally posted by @jhheider in #984 (comment)
@dosubot DosuBot
Copy link

dosubot bot commented Mar 14, 2024 •
edited

It sounds like you've done some thorough investigation into the issue and have identified the root cause as well as a potential solution. Your understanding of the changes in the libpkgx PR and how they relate to the assertion issue is impressive. If you're considering creating a PR to address this, your contribution would be greatly appreciated. Keep up the good work!

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

jhheider added a commit that referenced this issue Mar 14, 2024
@jhheider
fix Assertion failed: pkgx: env is being duped when multiple unicod…
1c893af 
…es in env

closes #988
@jhheider jhheider linked a pull request Mar 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix Assertion failed: pkgx: env is being duped when multiple unicodes in env pkgxdev/pkgx
1 participant
@jhheider