Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: getLocalBounds doesn't return correct values after removing a child #10451

Closed
talhaozdemir opened this issue Apr 16, 2024 · 1 comment · Fixed by #10488
Closed

Bug: getLocalBounds doesn't return correct values after removing a child #10451

talhaozdemir opened this issue Apr 16, 2024 · 1 comment · Fixed by #10488
Assignees
@GoodBoyDigital

Comments

@talhaozdemir
Copy link
Contributor

Current Behavior

Container getLocalBounds method doesn't return correct values after removing a child from the container

Expected Behavior

getLocalBounds adds removed objects bounds into account

Steps to Reproduce

For V7 (Working Fine)
For V8 (Buggy)

Environment

  • pixi.js version: e.g. 8.1.0
  • Browser & Version: e.g. Chrome 108

Possible Solution

No response

Additional Information

No response
@talhaozdemir talhaozdemir changed the title Bug: getLocalBounds doesn'treturn correct values after removing a child Bug: getLocalBounds doesn't return correct values after removing a child Apr 16, 2024
@GoodBoyDigital GoodBoyDigital mentioned this issue Apr 29, 2024
Merged
4 tasks
@GoodBoyDigital
Copy link
Member

great catch! found the issue and will be fixed in next release! 👍

@GoodBoyDigital GoodBoyDigital self-assigned this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GoodBoyDigital GoodBoyDigital

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: issue with local bounds cache not being invalidated when a child is removed pixijs/pixijs
2 participants
@GoodBoyDigital @talhaozdemir