Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Remove filter again (container.filters = null) throws error #10449

Open
Matt-Maerz opened this issue Apr 15, 2024 · 3 comments
Open

Bug: Remove filter again (container.filters = null) throws error #10449

Matt-Maerz opened this issue Apr 15, 2024 · 3 comments

Comments

@Matt-Maerz
Copy link

Matt-Maerz commented Apr 15, 2024

Current Behavior

Remove filter again (container.filters = null) throws error

loaders.mjs:1063 Uncaught TypeError: Cannot read properties of null (reading 'length')
at FilterSystem.push (loaders.mjs:1063:1)
at FilterPipe.execute (loaders.mjs:919:30)
at executeInstructions (filter-color-matrix.mjs:468:1)
at RenderGroupPipe.execute (filter-color-matrix.mjs:488:1)
at executeInstructions (filter-color-matrix.mjs:468:1)
at RenderGroupSystem.render (filter-fxaa.mjs:36:7)
at SystemRunner.emit (loaders.mjs:1423:1)
at WebGPURenderer.render (loaders.mjs:1589:27)
at Number.tickerAnimate (InitGame.js:829:14)
at TickerListener.emit (utils.mjs:581:1)

Expected Behavior

The filter should disappear from the Container

Steps to Reproduce

renderer = new PIXI.WebGPURenderer();
await renderer.init({
width: 1920,
height: 1080,
background: 0x000000
});
....
let blurFilter = new PIXI.BlurFilter({strength: 8, quality: 4});
tempContainer.filters = [blurFilter];
....
tempContainer.filters = null

Environment

  • pixi.js version 8.1.0
  • Browser Version 119.0.6045.200:
  • Windows Version 11 Home 23H2:

Possible Solution

Additional Information

@evan00144
Copy link

any update?

@Matt-Maerz
Copy link
Author

Matt-Maerz commented May 12, 2024

Workaround:
1.Step: "..filters[i].enabled = false" across all filters
2.Step: "....filters = null"

@GoodBoyDigital
Copy link
Member

GoodBoyDigital commented May 15, 2024

heya @Matt-Maerz , could you test the latest version pls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants