Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: [v8] arctifact when rendering big polygon with offscreen coordinates in Firefox and Safari #10435

Open
erikdubbelboer opened this issue Apr 10, 2024 · 7 comments
Assignees

Comments

@erikdubbelboer
Copy link

Current Behavior

Screenshot 2024-04-10 at 13 57 21

The two red areas left and right are rendered using Graphics.poly/fill. With 8.0.5 the line thought though the middle wasn't there but now with 8.1.0 it is there.

Expected Behavior

The line across the screen shouldn't be there.

Steps to Reproduce

I haven't had the time to create a small reproducible case. But seeing as other polygons that are small and fully in screen work well I think it has to do with the coordinates being outside of the canvas.

Environment

  • pixi.js version: 8.1.0
  • Browser & Version: Firefox and Safari (line is not there in Chrome)
  • OS & Version: Mac
  • Running Example: https://dubbelboer.com/sillysky.html go to the Mountain Valley level

Possible Solution

No response

Additional Information

No response

@erikdubbelboer
Copy link
Author

erikdubbelboer commented Apr 10, 2024

Firefox and Safari is because it only happens in webgl and this game has preference: 'webgpu'. Now that I removed the preference it also happens in Chrome with webgl.

@GoodBoyDigital
Copy link
Member

thanks for clarifying @erikdubbelboer !

@GoodBoyDigital
Copy link
Member

this looks like an artefact caused by the blur filter - would yo mind removing the blur to see if it disappears? Thank!!

@erikdubbelboer
Copy link
Author

Yes, removing the blur filter fixes it. I'm just doing:

        const filter = new BlurFilter({
            strength: 2,
            quality: 4,
        });
        this.filters = [filter];

Where this is a Container with the Graphics in it. I also have this in other places, but there the graphics don't go out of the screen, so that seems to have something to do with it.

@GoodBoyDigital
Copy link
Member

heya, this should be fixed in the current release - i had set the texture wrap modes to repeat in the last version. This was not a smart move - as it resulted in bleeding on filter textures. The next release, this should be back to clamp-to-edge and the issue will be resolved! Let me know! thanks!

@erikdubbelboer
Copy link
Author

@GoodBoyDigital what do you mean with the "current release", cause v8.1.0 is 3 weeks old and still has this issue?

@erikdubbelboer
Copy link
Author

@GoodBoyDigital the issue is still present in v8.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants