Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FilterState retains destroyed sprites #3973

Closed
lucap86 opened this issue Apr 26, 2017 · 3 comments · Fixed by #4897
Closed

FilterState retains destroyed sprites #3973

lucap86 opened this issue Apr 26, 2017 · 3 comments · Fixed by #4897
Labels
🕷 Bug Verified that it’s actually a legit bug that exists in the current release. 🔍 Needs Investigation Issue needs to be research or investigated further.

Comments

@lucap86
Copy link
Contributor

lucap86 commented Apr 26, 2017

Steps

  • Take heap snapshot
  • add some bunny
  • take heap snapshot
  • destroy bunnies container
  • collect garbage
  • take an heap snapshot
  • filter by "Objects allocated between Snapshow 1 and Snapshot 2"

Some destroyed sprites (and related resources like _boundsRect) are retained by FilterState
test

test.zip
@englercj
Copy link
Member

Good catch, thanks for the steps and test case. Hopefully we can take care of this soon.

@englercj englercj added Difficulty: Easy 🔍 Needs Investigation Issue needs to be research or investigated further. 🕷 Bug Verified that it’s actually a legit bug that exists in the current release. labels Apr 27, 2017
YahorPadlucki added a commit to YahorPadlucki/pixi.js that referenced this issue Mar 21, 2018
@YahorPadlucki
Destroy FilterState when object destroyed (pixijs#3973)
7f46125
@YahorPadlucki
Copy link

Hi @englercj, @lucap86 - can you check my PR for this issue?

YahorPadlucki added a commit to YahorPadlucki/pixi.js that referenced this issue Apr 11, 2018
@YahorPadlucki
Destroy FilterState when object destroyed (pixijs#3973)
c2232ba
YahorPadlucki added a commit to YahorPadlucki/pixi.js that referenced this issue Apr 11, 2018
@YahorPadlucki
Destroy FilterState when object destroyed (pixijs#3973)
9f0a0bd
ivanpopelyshev added a commit that referenced this issue May 6, 2018
@ivanpopelyshev
fix memory leak #3973
3755f5f
@ivanpopelyshev ivanpopelyshev mentioned this issue May 6, 2018
Merged
@lock
Copy link

lock bot commented May 8, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🕷 Bug Verified that it’s actually a legit bug that exists in the current release. 🔍 Needs Investigation Issue needs to be research or investigated further.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FilterState target leak pixijs/pixijs
3 participants
@englercj @YahorPadlucki @lucap86