Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsciiFilter does not work on mobile chrome #315

Open
freedompix opened this issue Dec 24, 2021 · 4 comments
Open

AsciiFilter does not work on mobile chrome #315

freedompix opened this issue Dec 24, 2021 · 4 comments

Comments

@freedompix
Copy link

example
https://www.pixiplayground.com/#/edit/qJK9vHZmkHQKruV6RbwtS
chrome 84.0.41
android 9

desktop test working correctly

@freedompix
Copy link
Author

i guess a main problem is a loosing sprite coords

@bencresty
Copy link

After just a quick test (no diving into the shader nor the code) I can confirm that when watching the exact link (so your code and the pixi playground) it's not working on Android 11 either (both Firefox and Chrome).

@bigtimebuddy bigtimebuddy transferred this issue from pixijs/pixijs Dec 28, 2021
@bigtimebuddy
Copy link
Member

Likely this is a shader issue. Here's the relevant code if some hero wants to investigate:

https://github.com/pixijs/filters/blob/main/filters/ascii/src/ascii.frag

@movAX13h
Copy link
Contributor

movAX13h commented Dec 29, 2022

On the playground page it does not work on my phone, but on the demo page it works fine:
https://filters.pixijs.download/main/demo/index.html?enabled=AsciiFilter

@freedompix can you confirm this?

I couldn't find issues in the shader. It is currently optimized for old devices, maybe too old and we could improve it by replacing the weird math it does to get the bit of a float by using bit operations but they are supported only starting at GLSL ES 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants