Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments not working correctly in pixelfed #5030

Open
xundeenergie opened this issue Apr 5, 2024 · 9 comments
Open

Comments not working correctly in pixelfed #5030

xundeenergie opened this issue Apr 5, 2024 · 9 comments

Comments

@xundeenergie
Copy link

xundeenergie commented Apr 5, 2024

i'm still fighting with comments on pixelfed...

Now i tried to comment a pixelfed-posting from friendica and pleroma.

Wenn i send the comment from pleroma, i get this in the nginx-log on pixelfed:

10.0.0.0 - - [05/Apr/2024:13:39:16 +0200] "POST /f/inbox HTTP/1.1" 200 5 "-" "Pleroma 2.5.0; https://pleroma.schuerz.at <email@adress>"                                                                        

And in pixelfed-log

Apr 05 13:39:19 srvimages japix[3750290]:   2024-04-05 11:39:18 App\Jobs\InboxPipeline\InboxWorker ............. RUNNING
Apr 05 13:39:19 srvimages japix[3750290]:   2024-04-05 11:39:18 App\Jobs\InboxPipeline\InboxWorker ........ 57.77ms DONE
Apr 05 13:39:19 srvimages japix[3750290]:   2024-04-05 11:39:18 App\Jobs\InboxPipeline\ActivityHandler ......... RUNNING
Apr 05 13:39:19 srvimages japix[3750290]:   2024-04-05 11:39:18 App\Jobs\InboxPipeline\ActivityHandler ..... 4.45ms DONE
Apr 05 13:39:31 srvimages japix[3750290]:   2024-04-05 11:39:30 App\Jobs\InboxPipeline\InboxWorker ............. RUNNING
Apr 05 13:39:31 srvimages japix[3750290]:   2024-04-05 11:39:30 App\Jobs\InboxPipeline\InboxWorker ........ 12.11ms DONE
Apr 05 13:40:01 srvimages japix[3750290]:   2024-04-05 11:40:00 App\Jobs\AvatarPipeline\AvatarStorageCleanup ... RUNNING
Apr 05 13:40:01 srvimages japix[3750290]:   2024-04-05 11:40:00 App\Jobs\AvatarPipeline\AvatarStorageCleanup  13.06ms DONE

When i post from friendica i get in nginx-log this:

138.201.0.0 - - [05/Apr/2024:13:43:00 +0200] "POST /f/inbox HTTP/1.1" 200 5 "-" "Friendica 'Yellow Archangel' 2024.06-dev-1559; https://soc.schuerz.at"

and in pixelfed-log:

Apr 05 13:43:03 srvimages japix[3750290]:   2024-04-05 11:43:03 App\Jobs\InboxPipeline\InboxWorker ............. RUNNING
Apr 05 13:43:03 srvimages japix[3750290]:   2024-04-05 11:43:03 App\Jobs\InboxPipeline\InboxWorker ........ 77.43ms DONE
Apr 05 13:43:03 srvimages japix[3750290]:   2024-04-05 11:43:03 App\Jobs\InboxPipeline\ActivityHandler ......... RUNNING
Apr 05 13:43:03 srvimages japix[3750290]:   2024-04-05 11:43:03 App\Jobs\InboxPipeline\ActivityHandler ... 119.46ms DONE

I can see the comments from friendica to the pixelfed-posting in pleroma and i can see the pleroma-comments on friendica.
But the pixelfed-posting has still zero comments...

I'm talking about this posting:
https://japix.schuerz.at/i/web/post/681751442790518858

This posting with comments in friendica
https://soc.schuerz.at/display/74e14928-cf6621d578335878-e848a90d

And now in pleroma
https://pleroma.schuerz.at/notice/AgZODkR0JLh4uni1WC
(Pleroma sends anonymous views directly to original pixelfed-posting!)

I'm running pixelfed develop, commit 8aae92d from 2024-03-10 05:44:24

@xundeenergie
Copy link
Author

My pixelfed-config .env is this:

APP_NAME="JaPix"                                                                                                                                                                                                   
APP_ENV=production                                                                                                                                                                                                 
APP_KEY=base64:klapofratzbumiifatzkeplemplem=                                                                                                                                                        
APP_DEBUG=true                                                                                                                                                                                                     
QUERY_LOG=false                                                                                                                                                                                                    
APP_LOCALE=de                                                                                                                                                                                                      
APP_URL=https://japix.schuerz.at                                                                                                                                                                                   
APP_DOMAIN="japix.schuerz.at"                                                                                                                                                                                      
ADMIN_DOMAIN="japix.schuerz.at"                                                                                                                                                                                    
SESSION_DOMAIN="japix.schuerz.at"                                                                                                                                                                                  
TRUST_PROXIES="*"                                                                                                                                                                                                  
LOG_CHANNEL=syslog                                                                                                                                                                                                 
DB_CONNECTION=pgsql                                                                                                                                                                                                
DB_HOST=127.0.0.1                                                                                                                                                                                                  
DB_PORT=5432                                                                                                                                                                                                       
DB_DATABASE=db-name                                                                                                                                                                                               
DB_USERNAME=db-username                                                                                                                                                                                               
DB_PASSWORD=verysecredpassword                                                                                                                                                                               
BROADCAST_DRIVER=redis
CACHE_DRIVER=redis
SESSION_DRIVER=redis
QUEUE_DRIVER=redis
REDIS_SCHEME=unix
REDIS_PATH=/run/redis/redis-server.sock
REDIS_DATABASE=0
REDIS_DRIVER=phpredis
MAIL_DRIVER=smtp
MAIL_HOST=localhost
MAIL_PORT=25
MAIL_ENCRYPTION=null
MAIL_FROM_ADDRESS="my@emailadress"
MAIL_FROM_NAME="Japix"
MAIL_SMTP_VERIFY_PEER=false
OPEN_REGISTRATION=false
ENFORCE_EMAIL_VERIFICATION=true
MAX_PHOTO_SIZE=16000
MAX_CAPTION_LENGTH=1000
MAX_ALBUM_LENGTH=15
MAX_BIO_LENGTH=500
ACTIVITY_PUB=true
AP_REMOTE_FOLLOW=true
AP_INBOX=true
AP_OUTBOX=true
AP_LOGGER_ENABLED=false
AP_SHARED_INBOX=true
ATOM_FEEDS=true
WEBFINGER=true
ADMIN_ENV_EDITOR=true
HORIZON_DARKMODE=true
MEDIA_EXIF_DATABASE=true
PAGE_404_HEADER="Entschuldigung, diese Seite gibt es nicht"
STORIES_ENABLED=true
OAUTH_ENABLED=true
ENABLE_CONFIG_CACHE=true
MEMORY_LIMIT=2500M
PF_MAX_USERS=1000
PF_COSTAR_ENABLED=true
INSTANCE_PUBLIC_HASHTAGS=true
INSTANCE_PUBLIC_LOCAL_TIMELINE=true
EXP_SPA=true
EXP_EMC=true
IMAGE_DRIVER=imagick
CUSTOM_EMOJI=true

@xundeenergie
Copy link
Author

my active php-modules

php-fpm8.2 -m                                                                                                                                           [15/1762]
[05-Apr-2024 14:08:44] NOTICE: PHP message: PHP Warning:  Module "bz2" is already loaded in Unknown on line 0                                                                                                      
[PHP Modules]                                                                                                                                                                                                      
bcmath                                                                                                                                                                                                             
bz2                                                                                                                                                                                                                
calendar                                                                                                                                                                                                           
cgi-fcgi                                                                                                                                                                                                           
Core                                                                                                                                                                                                               
ctype                                                                                                                                                                                                              
curl                                                                                                                                                                                                               
date                                                                                                                                                                                                               
dom                                                                                                                                                                                                                
exif                                                                                                                                                                                                               
FFI                                                                                                                                                                                                                
fileinfo                                                                                                                                                                                                           
filter                                                                                                                                                                                                             
ftp
gd
gettext
hash
iconv
igbinary
imagick
intl
json
ldap
libxml
mbstring
openssl
pcre
PDO
pdo_pgsql
pgsql
Phar
posix
random
readline
redis
Reflection
session
shmop
SimpleXML
sockets
sodium
SPL
standard
sysvmsg
sysvsem
sysvshm
tokenizer
xml
xmlreader
xmlwriter
xsl
Zend OPcache
zip
zlib

[Zend Modules]
Zend OPcache

@xundeenergie
Copy link
Author

Still no comments visible on pixelfed
image

@xundeenergie
Copy link
Author

xundeenergie commented Apr 6, 2024

A friend reported, on his pixelfed (his user follows mine) there are also no comments visible.

I made one comment from my pixelfedaccount. This is visible. Also on his instance.

What i complain is:
I write a comment from friendica on a pixelfed-posting. Pixelfed does not show it.
But on pleroma i receive an see this comment. The pleroma-user is NOT mentioned in friendica!
And vice versa, comments on pleroma are sent to the followers from pixelfed-users, but are not shown in pixelfed.

And comments from other services to pixelfed are also not shown in other pixelfed-instances...

So comments seem very broken in pixelfed.

@xundeenergie
Copy link
Author

I digged more into the logfiles from pleroma, friendica and pixelfed.

When i post a comment in friendica, i see this:

2024-04-06T08:51:38Z worker [INFO]: Delivery via ActivityPub {"cmd":"wall-new","id":18390095,"inbox":"https://japix.schuerz.at/f/inbox","worker_id":"78f5207","worker_cmd":"Notifier"} - {"file":"Notifier.php","li
ne":883,"function":"activityPubDelivery","request-id":"66110d1990592","stack":"Notifier::activityPubDelivery (190), Notifier::execute, Worker::execFunction (388), Worker::execute (123), Worker::processQueue (87)
","uid":"7d5c4a","process_id":2722635}
2024-04-06T08:51:38Z worker [INFO]: Delivery via ActivityPub {"cmd":"wall-new","id":18390095,"inbox":"https://pleroma.schuerz.at/inbox","worker_id":"78f5207","worker_cmd":"Notifier"} - {"file":"Notifier.php","li
ne":883,"function":"activityPubDelivery","request-id":"66110d1990592","stack":"Notifier::activityPubDelivery (190), Notifier::execute, Worker::execFunction (388), Worker::execute (123), Worker::processQueue (87)
","uid":"7d5c4a","process_id":2722635}


It seems, that friendica sends the comments directly to pixelfed AND pleroma.

And in pleroma i get this:

Apr 06 10:53:40 sc-blog-01 pleroma[363173]: [debug] Federating https://pleroma.schuerz.at/activities/67695479-9261-4d14-ad8f-46e351f8504b to https://japix.schuerz.at/f/inbox                                      
Apr 06 10:53:41 sc-blog-01 pleroma[363173]: [debug] Federating https://pleroma.schuerz.at/activities/67695479-9261-4d14-ad8f-46e351f8504b to https://soc.schuerz.at/inbox

So it seems, that pleroma does the same... federating the comment to pixelfed and friendica. Event without mentioning the other user, just in case they are part of the thread.

@xundeenergie
Copy link
Author

xundeenergie commented Apr 6, 2024

I made this comment
https://soc.schuerz.at/display/4edd2508-1566-1110-6797-b26417202078

It is shown in pleroma (in case of direct federation).
But it is NOT shown in Pixelfed, even it got federated to pixelfed.

Pixelfed received it:
friendica.log

2024-04-06T09:05:45Z worker [INFO]: Delivery via ActivityPub {"cmd":"wall-new","id":18390426,"inbox":"https://japix.schuerz.at/f/inbox","worker_id":"edeb91e","worker_cmd":"Notifier"} - {"file":"Notifier.php","li
ne":883,"function":"activityPubDelivery","request-id":"661110683a91d","stack":"Notifier::activityPubDelivery (190), Notifier::execute, Worker::execFunction (388), Worker::execute (123), Worker::processQueue (87)
","uid":"d71c48","process_id":2726020}                                                                                                                                                                             
2024-04-06T09:05:45Z worker [INFO]: Delivery via ActivityPub {"cmd":"wall-new","id":18390426,"inbox":"https://pleroma.schuerz.at/inbox","worker_id":"edeb91e","worker_cmd":"Notifier"} - {"file":"Notifier.php","li
ne":883,"function":"activityPubDelivery","request-id":"661110683a91d","stack":"Notifier::activityPubDelivery (190), Notifier::execute, Worker::execFunction (388), Worker::execute (123), Worker::processQueue (87)
","uid":"d71c48","process_id":2726020}

and Pixelfed-Log

Apr 06 11:05:49 srvimages japix[3911070]:   2024-04-06 09:05:48 App\Jobs\InboxPipeline\InboxWorker ............. RUNNING
Apr 06 11:05:49 srvimages japix[3911070]:   2024-04-06 09:05:48 App\Jobs\InboxPipeline\InboxWorker ........ 79.14ms DONE
Apr 06 11:05:49 srvimages japix[3911070]:   2024-04-06 09:05:48 App\Jobs\InboxPipeline\ActivityHandler ......... RUNNING
Apr 06 11:05:49 srvimages japix[3911070]:   2024-04-06 09:05:48 App\Jobs\InboxPipeline\ActivityHandler ... 108.63ms DONE

(the 2 hours difference is in case of timesettings for logging... Servertime is the same on all servers)

@xundeenergie
Copy link
Author

Ok...

When i comment from pleroma to pixelfed.social or japix.schuerz.at, then the comment will be sent to all followers of my pleroma-account. Independend if the follow the pixelfed-account.

So this miracle in different behaviour of japix.schuerz.at and pixelfed.social is solved.

The other thing is still open:
Why are friendica-comments not shown in pixelfed.social and japix.schuerz.at
And why are pleroma-comments shown in pixelfed.social but not in japix.schuerz.at

@xundeenergie
Copy link
Author

How can i debug, why friendica-comments are not displayed?

@kr428
Copy link

kr428 commented Apr 23, 2024

Same here at the moment.

Post:
https://pixelfed.social/i/web/post/688338547392780333

Comment:
https://loma.ml/display/373ebf56-7766-279b-2180-06b642284093

Comment apparently (as far as I can tell) has been sent out correctly but doesn't display on the pixelfed end of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants