Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounding in History #4

Open
jrmiller82 opened this issue Jul 7, 2018 · 3 comments
Open

Rounding in History #4

jrmiller82 opened this issue Jul 7, 2018 · 3 comments

Comments

@jrmiller82
Copy link

Here's a feature request:

Can we get a rounding capability when we pull history? I.e. if I pull symbol "MCD", I only need a quote like Open: 159.62 instead of 159.6200051825049032. Maybe "significance" variable in history.Params with constant similar to how you've done history.Interval ?

@maximus12793
Copy link

maximus12793 commented Jul 7, 2018 via email

@jrmiller82
Copy link
Author

Fair enough.

@ackleymi
Copy link
Contributor

Yeah I've been debating how I want to handle problems with the floats that get returned in some responses. Leaving it up to end-users for now, but I'll keep your suggestions in mind. Please be aware that the history package has been migrated to the chart package to solve some internal consistency issues and the datetime package now handles converting between time structs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants