Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Votemap nominations doesn't work if name isn't in lowercase #782

Closed
ThatRoboticFish opened this issue Apr 15, 2024 · 0 comments · Fixed by #792
Closed

Votemap nominations doesn't work if name isn't in lowercase #782

ThatRoboticFish opened this issue Apr 15, 2024 · 0 comments · Fixed by #792
Assignees
@utf-4096
Labels
bug This issue reports a bug in piqueserver code and/or docs priority:normal This issue has a limited impact or is only noticable in specific circumstances scripts This issue is related to piqueserver's bundled scripts or piqueserver's scripts API
Milestone
1.2.1

Comments

@ThatRoboticFish
Copy link

ThatRoboticFish commented Apr 15, 2024 •
edited

Describe the bug
When nominating a map with /vote that contains capital letters, an error will appear saying that this map doesn't exist on the console, but when typing another map with lowercase letters, it will work. This also causes the command to break when trying to select another map if this bug is present.

imagen
imagen
imagen

To Reproduce
Steps to reproduce the behavior:

  1. Enable piqueserver.scripts.votemap (with public_votes on True) and join the server
  2. Run command /vote and select any map that contains capital letters
  3. See error
  4. Vote another map with /vote and you will see that the script will try to change to the previous voted map

Expected behavior
Change to the voted map.

Stack Trace or logs
https://gist.github.com/ThatRoboticFish/08cdab70cdfa4ed23353d6c65f4f3e8c

Server (please complete the following information):

  • OS/Version: Debian 11
  • Piqueserver Version: piqueserver 1.1.1
  • Installation Method: pip

Client (if relevant)

Additional context
None.
@ThatRoboticFish ThatRoboticFish added bug This issue reports a bug in piqueserver code and/or docs triage The Priority of this Bug has not been decided yet. labels Apr 15, 2024
@utf-4096 utf-4096 self-assigned this May 15, 2024
@utf-4096 utf-4096 added scripts This issue is related to piqueserver's bundled scripts or piqueserver's scripts API priority:normal This issue has a limited impact or is only noticable in specific circumstances and removed triage The Priority of this Bug has not been decided yet. labels May 15, 2024
@utf-4096 utf-4096 added this to the 1.2.1 milestone May 15, 2024
@utf-4096 utf-4096 mentioned this issue May 28, 2024
Merged
@ThatRoboticFish ThatRoboticFish changed the title Votemap nomiations doesn't work if name isn't in lowercase Votemap nominations doesn't work if name isn't in lowercase May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@utf-4096 utf-4096

Labels
bug This issue reports a bug in piqueserver code and/or docs priority:normal This issue has a limited impact or is only noticable in specific circumstances scripts This issue is related to piqueserver's bundled scripts or piqueserver's scripts API
Projects
None yet
Milestone
1.2.1
Development

Successfully merging a pull request may close this issue.

fix(scripts/votemap): don't lowercase the rotation names piqueserver/piqueserver
2 participants
@utf-4096 @ThatRoboticFish