You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Looks like docker isnt able to run by default, it executes piqueserver -d /config, but the /config directory seems to be empty.
To Reproduce
Steps to reproduce the behavior:
# docker build -t piqueserver .
# docker run piqueserver
Expected behavior
It should run even without specifying the config dir.
Stack Trace or logs
Loading config from '/config/config.json'
Could not open Config file
[Errno 2] No such file or directory: '/config/config.json'
Server (please complete the following information):
Docker from latest commit
Additional context
It looks for the files on /config, but we never copy any file to that directory, so i suppose it should run piqueserver on piqueserver/config or do a COPY piqueserver/config /config. Im not too familiar with dockers, but it looks like a bug for me.
The text was updated successfully, but these errors were encountered:
DryByte
added
bug
This issue reports a bug in piqueserver code and/or docs
triage
The Priority of this Bug has not been decided yet.
labels
Feb 28, 2023
DryByte
changed the title
Docker not runs
Docker not runs if you don't specify the server directory
Feb 28, 2023
The general way you're supposed to use this is to mount your config directory into the image using -v mydir:/config.
Copying the default config into the image would mean that it is impossible to change the config of the server, so that wouldn't be very good.
One way to handle this could be to make the entrypoint script run --copy-config if the config directory is empty. However this means that unless you set up a volume mount as above, all of your data will be lost after a restart.
So the current solution is just a compromise of the two. It should probably just be documented better.
Hmm, i guess so. I was thinking about trying to detect if user passes the volume parameter to docker, then can be sent a warning to the user warning him about that... But looks like its not possible.
Making an "auto setup/run" script its bad for it? So, people can just run the script and get it working quick.
Yes, but its not possible to send any warning to the user saying to use -v so he can change the server config and save the server state. But, i guess its the best option to add the copy config.
Describe the bug
Looks like docker isnt able to run by default, it executes piqueserver -d /config, but the /config directory seems to be empty.
To Reproduce
Steps to reproduce the behavior:
# docker build -t piqueserver .
# docker run piqueserver
Expected behavior
It should run even without specifying the config dir.
Stack Trace or logs
Server (please complete the following information):
Additional context
It looks for the files on /config, but we never copy any file to that directory, so i suppose it should run piqueserver on piqueserver/config or do a
COPY piqueserver/config /config
. Im not too familiar with dockers, but it looks like a bug for me.The text was updated successfully, but these errors were encountered: