Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teamkilling does not behave as expected #706

Open
MuffinTastic opened this issue Dec 9, 2021 · 0 comments
Open

Teamkilling does not behave as expected #706

MuffinTastic opened this issue Dec 9, 2021 · 0 comments
Labels
bug This issue reports a bug in piqueserver code and/or docs config options This issue relates to piqueserver's configuration options (if it's a bug, apply the bug label too)

Comments

@MuffinTastic
Copy link
Contributor

MuffinTastic commented Dec 9, 2021

Setting friendly_fire to true in the config should allow you to kill your teammates whenever you like, but it doesn't. This was caused by a change in how teamkilling configuration is handled, namely commit 93d0d48.

The previous logic for teamkilling was: off/false, only on_grief, on/true.

The current logic is: friendly_fire and teamkilling on grief now act entirely independently, with the introduction of friendly_fire_on_grief. The surrounding code was never updated to reflect that though, so when friendly_fire_on_grief is true it ends up following the code path previously meant for when friendly_fire was on_grief, and returning when you haven't griefed anything recently, even if friendly_fire is true.

#448 is a symptom of this.

My recommendation is honestly just to revert it back to the way it was. Remove friendly_fire_on_grief, add "on_grief" back as an option for friendly_fire.

@MuffinTastic MuffinTastic added bug This issue reports a bug in piqueserver code and/or docs triage The Priority of this Bug has not been decided yet. labels Dec 9, 2021
@NotAFile NotAFile added config options This issue relates to piqueserver's configuration options (if it's a bug, apply the bug label too) and removed triage The Priority of this Bug has not been decided yet. labels Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue reports a bug in piqueserver code and/or docs config options This issue relates to piqueserver's configuration options (if it's a bug, apply the bug label too)
Projects
None yet
Development

No branches or pull requests

2 participants