Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError in the console (due to @player_only) #610

Closed
EvgenZhaba opened this issue Nov 25, 2020 · 0 comments · Fixed by #791
Closed

TypeError in the console (due to @player_only) #610

EvgenZhaba opened this issue Nov 25, 2020 · 0 comments · Fixed by #791
Assignees
@utf-4096
Labels
bug This issue reports a bug in piqueserver code and/or docs core commands This issues involves piqueserver's core commands priority:low This issue has a very low impact or is only noticable in rare circumstances
Milestone
1.2.1

Comments

@EvgenZhaba
Copy link
Contributor

Describe the bug
Commands with "@player_only" like some(connection, value) throw TypeError to the console when they enter an empty argument.
For example, "/login" or "/vote" from "piqueserver.scripts.votemap" script.

To Reproduce
Steps to reproduce the behavior:

  1. (optionally) include "piqueserver.scripts.daycycle" in the config
  2. run piqueserver
  3. join to the server and send the command "/login"
  4. (optionally) and send "/vote"

Stack Trace or logs
https://gist.github.com/EvgenZhaba/468c5d3f84f6ca55d6070082e9e69009
this line https://github.com/piqueserver/piqueserver/blob/master/piqueserver/commands.py#L268

Additional context
I tried to create a user script with my "login" command: copied everything from the original, but removed the "@player_only" and everything seems to work.
@EvgenZhaba EvgenZhaba added bug This issue reports a bug in piqueserver code and/or docs triage The Priority of this Bug has not been decided yet. labels Nov 25, 2020
@utf-4096 utf-4096 self-assigned this May 22, 2024
@utf-4096 utf-4096 added core commands This issues involves piqueserver's core commands priority:low This issue has a very low impact or is only noticable in rare circumstances and removed triage The Priority of this Bug has not been decided yet. labels May 25, 2024
@utf-4096 utf-4096 added this to the 1.2.1 milestone May 25, 2024
@utf-4096 utf-4096 mentioned this issue May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@utf-4096 utf-4096

Labels
bug This issue reports a bug in piqueserver code and/or docs core commands This issues involves piqueserver's core commands priority:low This issue has a very low impact or is only noticable in rare circumstances
Projects
None yet
Milestone
1.2.1
Development

Successfully merging a pull request may close this issue.

fix(commands): calculate the right number of params for decorators piqueserver/piqueserver
2 participants
@EvgenZhaba @utf-4096