Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reset() does not postpone a deferred since we switched to AsyncIOReactor #481

Closed
Kuunikal opened this issue Apr 4, 2019 · 7 comments
Closed

reset() does not postpone a deferred since we switched to AsyncIOReactor #481

Kuunikal opened this issue Apr 4, 2019 · 7 comments
Labels
bug This issue reports a bug in piqueserver code and/or docs not-our-bug priority:normal This issue has a limited impact or is only noticable in specific circumstances scripts This issue is related to piqueserver's bundled scripts or piqueserver's scripts API waiting uptream This issue is waiting for upstream to release a new version, which fixes its problem

Comments

@Kuunikal
Copy link

Kuunikal commented Apr 4, 2019 •
edited

Server is configured for a 15-minute kick. However, players were getting kicked randomly, despite moving right before the kick.

Happened when using the voxlap client and OpenSpades 0.1.3.

Player join time:

2019-04-04T01:15:07+0000 [piqueserver.player#info]   πâ₧πâòπéúπâ│ (IP xx.xx.xx.xx, ID 1) entered the game!

Console at time of event:

2019-04-04T01:30:01+0000 [piqueserver.player#info]   マフィン disconnected!
2019-04-04T01:30:09+0000 [piqueserver.player#info]   マフィン (IP xx.xx.xx.xx, ID 1) entered the game!
2019-04-04T01:30:11+0000 [piqueserver.player#info] <Ku> wtf lol
2019-04-04T01:30:12+0000 [piqueserver.player#info] <  マフィン> random disconnect
2019-04-04T01:30:17+0000 [piqueserver.player#info] <Ku> it said inactive after 1 minute

View in-game at time of event:

image
@Kuunikal Kuunikal added bug This issue reports a bug in piqueserver code and/or docs triage The Priority of this Bug has not been decided yet. labels Apr 4, 2019
@NotAFile NotAFile added priority:high This issue is immediately noticable during normal use scripts This issue is related to piqueserver's bundled scripts or piqueserver's scripts API and removed triage The Priority of this Bug has not been decided yet. labels Apr 4, 2019
@NotAFile NotAFile added this to the 1.0.0 milestone Apr 4, 2019
@NotAFile
Copy link
Member

NotAFile commented Apr 4, 2019 •
edited

This is an issue with upstream twisted. The AsyncIOReactor implementation of IDelayedCall does not seem to have a working implementation of .reset(), which afk.py uses.

I'll see if we can get a workaroud

@NotAFile
Copy link
Member

NotAFile commented Apr 4, 2019

instead of reset, cancel() and do a new callLater
but probably also file a bug report in the issue tracker so somebody fixes it :)

NotAFile added a commit that referenced this issue Apr 5, 2019
@NotAFile
work around DelayedCall.reset() issue in afk.py
55f9a09 
see #481
@NotAFile
Copy link
Member

NotAFile commented Apr 5, 2019 •
edited

I've pushed a quick workaround for this

the ticked for this is: https://twistedmatrix.com/trac/ticket/9611

@NotAFile NotAFile changed the title Random kick for 1 minute of inactivity reset() does not postpone a deferred Apr 5, 2019
@NotAFile NotAFile changed the title reset() does not postpone a deferred reset() does not postpone a deferred since we switched to AsyncIOReactor Apr 5, 2019
@NotAFile NotAFile added not-our-bug priority:normal This issue has a limited impact or is only noticable in specific circumstances waiting uptream This issue is waiting for upstream to release a new version, which fixes its problem and removed priority:high This issue is immediately noticable during normal use labels Apr 5, 2019
godwhoa added a commit that referenced this issue Apr 5, 2019
@godwhoa
work around DelayedCall.reset() issue
58e683e 
see #481
@godwhoa godwhoa mentioned this issue Apr 5, 2019
Merged
godwhoa added a commit that referenced this issue Apr 5, 2019
@godwhoa
work around DelayedCall.reset() issue
a423aab 
see #481
@NotAFile NotAFile removed this from the 1.0.0 milestone Apr 5, 2019
@NotAFile
Copy link
Member

NotAFile commented Dec 1, 2019

https://twistedmatrix.com/trac/ticket/9611#comment:4 has a workaround monkeypatch

@NotAFile
Copy link
Member

twisted/twisted#1232 will fix this once merged

@NotAFile
Copy link
Member

Fixed upstream. Not released yet.

@utf-4096
Copy link
Member

Fix was released a long time ago, closing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue reports a bug in piqueserver code and/or docs not-our-bug priority:normal This issue has a limited impact or is only noticable in specific circumstances scripts This issue is related to piqueserver's bundled scripts or piqueserver's scripts API waiting uptream This issue is waiting for upstream to release a new version, which fixes its problem
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NotAFile @utf-4096 @Kuunikal