Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use the variable name "values" in the examples #1438

Open
mirams opened this issue Feb 22, 2022 · 0 comments
Open

Don't use the variable name "values" in the examples #1438

mirams opened this issue Feb 22, 2022 · 0 comments

Comments

@mirams
Copy link
Member

mirams commented Feb 22, 2022

values is just the same as saying numbers - which isn't a very helpful variable name :-)

It means at least two distinct things that are not the same in here: https://github.com/pints-team/pints/blob/master/examples/stats/custom-model.ipynb

Either simulated_data or model_output or whatever would be better, or even just y to match the maths at the top for some of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants