Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the bender API to look more like jbender #17

Open
cgordon opened this issue Oct 16, 2017 · 2 comments
Open

Update the bender API to look more like jbender #17

cgordon opened this issue Oct 16, 2017 · 2 comments
Assignees

Comments

@cgordon
Copy link
Collaborator

cgordon commented Oct 16, 2017

The API for bender was created before the API for jbender (see https://github.com/pinterest/jbender). The API for jbender is more elegant and requires a LOT less memory allocations in the main loop (as it sends far fewer events). This would be a non-backwards compatible change, but given the way people vendor dependencies that should be alright for existing users.

@nuance
Copy link

nuance commented Oct 17, 2017

The API should probably also be tweaked to use time.Duration and other non-numeric types where appropriate.

@cgordon
Copy link
Collaborator Author

cgordon commented Oct 18, 2017

Agreed, in fact, I made very poor use of the Go type system in all of this project, and it is due for a major overhaul.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants