Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PINAnimatedImageView not displaying an image in some scenarios #591

Open
MikeMcNamara opened this issue Dec 3, 2020 · 1 comment
Open

Comments

@MikeMcNamara
Copy link

In a number of places where we set the image property in PINAnimatedImageView, no image is appearing. We have traced this back to the following line, where you clear the contents of the UIImageView's layer contents. When this line is commented, the images appear correctly.

We subclass PINAnimatedImageView and have managed to workaround this issue by calling [self.layer setNeedsDisplay] right after setting the image in this subclass. We do it in the image setter as follows:

- (void)setImage:(UIImage *)image {
    [super setImage:image];
    [self.layer setNeedsDisplay];
}

Setup:

PINRemoteImage 3.0.3
Xcode 12.2
All devices tested (both simulators and real devices)

Getting this issue addressed would be great if possible! Thanks 🙏

@alex-vasenin
Copy link

Could it be related to #517? It seems like your workaround helps with it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants