Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarklet should allow uploading file #66

Open
lapo-luchini opened this issue May 29, 2014 · 7 comments · May be fixed by #216
Open

Bookmarklet should allow uploading file #66

lapo-luchini opened this issue May 29, 2014 · 7 comments · May be fixed by #216
Labels
enhancement A feature request or general improvement javascript Pull requests that update Javascript code

Comments

@lapo-luchini
Copy link
Contributor

(enhancement request)
Some websites check images for Referrer and/or origin IP.
It would be nice to add to the bookmarklet landing page a checkbox to upload local image instead of delegating the download to the server (and maybe even doing that automatically when the server-side download fails).

@overshard
Copy link
Member

I'm reworking the bookmarklet entirely. CSP is causing issues with just allowing the bookmarklet to run. I'm working on a new solution that bypasses this by grabbing the image and uploading it from the user's browser instead of pulling an image from the server.

@lapo-luchini
Copy link
Contributor Author

Any news on that approach?
If it's possible already server-side, I could help bookmarklet-side.

@winkidney
Copy link
Member

No progress on this feature currently. I'm working on the new UI built by vue.js with Bluma(like bootstrap).
Once that work done, we may have time to add this feature ( to both bookmarklet or browser-extension are okay).
I have tried a image-resource manager application named eagle, you could pull any image on the page to a specified eagle area to upload it to your eagle manager.
The UX of eagle chrome extension works like a charm and make me feel excellent, you chould have a try if you have time : )

@lapo-luchini
Copy link
Contributor Author

I like Vue.JS a lot too (so maybe I can help on the client-side of Pinry in the future, even if I don't know any Python), but I'd like to keep the bookmarklet as lean as possible, and using only VanillaJS as far as possible. But that doesn't make it easy to upload a local URL… or maybe yes, the image is probably cached (and thus, avoid origial website Refer checks) even when called from a different tab (the bookmarklet opens a new one).

@winkidney
Copy link
Member

@lapo-luchini Keep bookmarket alone make sense!

@overshard
Copy link
Member

Basically the image we find on a website should be uploaded via the bookmarklet directly to pinry and not pulled via the pinry server, it would solve a lot of issues...

@overshard overshard added enhancement A feature request or general improvement javascript Pull requests that update Javascript code labels Dec 8, 2019
@winkidney
Copy link
Member

winkidney commented Dec 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature request or general improvement javascript Pull requests that update Javascript code
Development

Successfully merging a pull request may close this issue.

3 participants