Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate connection dependency scenario. Consider if it should be an error. #58

Open
samir-gandhi opened this issue Feb 14, 2023 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers size/small Small change (e.g. adding a small number of parameters to an existing resource/datasource schema) status/triaged The issue/PR has completed initial triage and needs assignment

Comments

@samir-gandhi
Copy link
Contributor

Actual Behavior

When there are connections or subflows that are not mapped, we produce a warning

Warning: Unmapped Connection Dependency
│
│   with davinci_flow.sub_mgr_approval,
│   on dv.tf line 20, in resource "davinci_flow" "sub_mgr_approval":
│   20: resource "davinci_flow" "sub_mgr_approval" {
│
│ Flow '[Sub] Manager Approval
│ ' contains connection 'Amazon Simple Email [2022-11-11]' which is not defined in dependent connections.
│ This may lead to autogeneration of unmanaged connections or incorrect connection mapping
│
│ (and 32 more similar warnings elsewhere)

If it is not a bootstrapped connection, there is a very high chance that a subsequent apply will lead to a broken flow.

Steps to Reproduce

terraform apply a davinci_flow that points to a non-bootstrapped connection.
Will see the warning, then another apply should lead to a failed flow deploy.

@samir-gandhi samir-gandhi added the type/enhancement New feature or request label Feb 14, 2023
@patrickcping patrickcping added type/bug Something isn't working status/needs-triage The issue/PR needs initial triage and removed type/enhancement New feature or request labels Dec 29, 2023
@patrickcping
Copy link
Contributor

Needs re-triage to determine if there is any change to be made

@samir-gandhi
Copy link
Contributor Author

It feels that we are settled on the code, but this could use help via additional documentation on: https://terraform.pingidentity.com/getting-started/davinci/

@samir-gandhi samir-gandhi added documentation Improvements or additions to documentation status/triaged The issue/PR has completed initial triage and needs assignment size/small Small change (e.g. adding a small number of parameters to an existing resource/datasource schema) good first issue Good for newcomers and removed type/bug Something isn't working status/needs-triage The issue/PR needs initial triage labels Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers size/small Small change (e.g. adding a small number of parameters to an existing resource/datasource schema) status/triaged The issue/PR has completed initial triage and needs assignment
Projects
None yet
Development

No branches or pull requests

2 participants