Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make score computation at the python level #73

Open
codersquid opened this issue May 14, 2015 · 3 comments
Open

Make score computation at the python level #73

codersquid opened this issue May 14, 2015 · 3 comments

Comments

@codersquid
Copy link
Contributor

euroscipy/symposion has a couple of changes, and I'm opening issues for them. I don't know if this change fixes a problem (the other one did).
euroscipy@112123b

@brosner
Copy link
Member

brosner commented May 15, 2015

@codersquid thank you for the report! Can you provide more details about why we need to ditch ProposalScoreExpression in favor of the Python version?

@codersquid
Copy link
Contributor Author

@brosner Hi, I haven't actually looked in to the commit from @pdebuyl. I opened this issue since they had fixed something in one of the other commits, and I don't want to any of their other fixes to get lost. This change may just be a preference versus a fix. I've been hoping for some time to dig in to it.

@pdebuyl
Copy link

pdebuyl commented May 28, 2015

This part of the code was broken for EuroSciPy 2014. I didn't explain the bug in the commit message which is a bit annoying in retrospect.

From memory, I can think of two causes:

  • The Decimal module complained with an error.
  • The sql request refused to execute.

As I couldn't fix those problems, I saw the Python way as simpler and more robust.

@ossanna16 ossanna16 changed the title make score computation at the python level Make score computation at the python level Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants