Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove django-reversion dependency #56

Open
jacobwegner opened this issue Sep 11, 2017 · 2 comments
Open

Remove django-reversion dependency #56

jacobwegner opened this issue Sep 11, 2017 · 2 comments

Comments

@jacobwegner
Copy link
Contributor

As #33 notes, there is a backwards-incompatible change to django-reversion that breaks semantic versioning.

Rather than pinning to a particular version or updating pinax_teams to be compatible, I'm wondering if we instead just drop the django-reversion requirement.

If desired, membership changes could be tracked via signals and a library like pinax_eventlog, but currently reversion might be a bit overkill for the intended use-case of pinax-teams.

@paltman
Copy link
Member

paltman commented Jan 12, 2018

Yes! Let's kill it.

@grahamu
Copy link
Contributor

grahamu commented Jan 20, 2018

As mentioned in the "django-20" branch merge, I have kept django-reversion in this project for the initial Django v2.0 compatible release so existing users have a path forward.

Let's examine whether a dev can add django-reversion to pinax-teams models within their own project and remove django-reversion if that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants