Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Tiered Pricing Plans #629

Open
wants to merge 14 commits into
base: original
Choose a base branch
from
Open

Add Support for Tiered Pricing Plans #629

wants to merge 14 commits into from

Conversation

jksimoniii
Copy link

What's this PR do?

  • Models Tiers as they appear in Stripe
  • Accounts for tiers during the sync_plans command
  • Implements Plan.calculate_total_amount
  • Update Subscription to use Plan.calculate_total_amount

Any background context you want to provide?

Stripe Tiered Pricing Docs

What ticket or issue # does this fix?

Closes #628

Definition of Done (check if considered and/or addressed):

  • Are all backwards incompatible changes documented in this PR?
  • Have all new dependencies been documented in this PR?
  • Has the appropriate documentation been updated (if applicable)?
  • Have you written tests to prove this change works (if applicable)?

@codecov
Copy link

codecov bot commented Feb 3, 2019 •
edited

Codecov Report

Merging #629 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
+ Coverage   99.21%   99.23%   +0.02%     
==========================================
  Files          33       33              
  Lines        1911     1967      +56     
  Branches      175      185      +10     
==========================================
+ Hits         1896     1952      +56     
  Misses          7        7              
  Partials        8        8
Flag Coverage Δ
#py27dj110 98.93% <100%> (+0.03%) ⬆️
#py27dj111 98.93% <100%> (+0.03%) ⬆️
#py27dj18 99.18% <100%> (+0.02%) ⬆️
#py34dj110 98.93% <100%> (+0.03%) ⬆️
#py34dj111 98.93% <100%> (+0.03%) ⬆️
#py34dj18 99.18% <100%> (+0.02%) ⬆️
#py34dj20 98.93% <100%> (+0.03%) ⬆️
#py35dj110 98.93% <100%> (+0.03%) ⬆️
#py35dj111 98.93% <100%> (+0.03%) ⬆️
#py35dj18 99.18% <100%> (+0.02%) ⬆️
#py35dj20 98.93% <100%> (+0.03%) ⬆️
#py36dj111 98.93% <100%> (+0.03%) ⬆️
#py36dj20 98.93% <100%> (+0.03%) ⬆️
#py36dj20psql 98.93% <100%> (+0.03%) ⬆️
Impacted Files Coverage Δ
pinax/stripe/utils.py 100% <100%> (ø) ⬆️
pinax/stripe/models.py 100% <100%> (ø) ⬆️
pinax/stripe/managers.py 100% <100%> (ø) ⬆️
pinax/stripe/actions/plans.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0005850...4104c7d. Read the comment docs.

@paltman paltman changed the base branch from master to 4.x November 26, 2021 15:55
@paltman paltman added the Original The original full pinax-stripe version with cached models and actions service layer label Nov 26, 2021
@paltman paltman changed the base branch from 4.x to original November 26, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Original The original full pinax-stripe version with cached models and actions service layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Tiered Metered Usage Plans
2 participants
@jksimoniii @paltman