Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: invalid-option message pop up in every product object. #16991

Open
abdelrhmanyosry opened this issue Apr 26, 2024 · 4 comments
Open

[Bug]: invalid-option message pop up in every product object. #16991

abdelrhmanyosry opened this issue Apr 26, 2024 · 4 comments
Labels

Comments

@abdelrhmanyosry
Copy link

Pimcore version

11

Steps to reproduce

migrate some products using any api and entering invalid options for select options input
image
image

Actual Behavior

migrate some products using any api and entering invalid options for select options input
I want to show an empty option in case the value that has been sent from the API is not valid instead of showing this annoying message

this error happened because I sent a value 2 to this attribute
image

what I expect in case I sent the wrong value to show an empty option without displaying this message.

image

Expected Behavior

when I import the wrong value in the select-option attribute this message don't pop up and instead shows an empty option
image

@fashxp
Copy link
Member

fashxp commented Apr 29, 2024

but then you would have no chance of knowing, that in DB there is actually a invalid value, right?

@abdelrhmanyosry
Copy link
Author

@fashxp It doesn't matter from my perspective if I entered the wrong value just displays the empty value in the select option. I can review data-import logs to see if I entered the incorrect value for this attribute. Still, an invalid pop message is annoying for my client especially since we have many select options attributes. Hence, in case I entered 3-4 wrong values I get 4 different invalid option messages so when the client displays the object he should click for time on the message above not a good practice. I think it will be better if the invalid-option message has more info so I can detect which attribute causes the problem.

@fashxp
Copy link
Member

fashxp commented Apr 30, 2024

with having a better error message I fully agree! But we should not ignore that case completely.

@abdelrhmanyosry
Copy link
Author

@fashxp can i extend the built-in class in data-importer and in case i didn't find the value in the select input, i can just set it as empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants