Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix database error when filtering in localized field in the object search #16971

Merged
merged 3 commits into from May 3, 2024
Merged

Fix database error when filtering in localized field in the object search #16971

merged 3 commits into from May 3, 2024

Conversation

blankse
Copy link
Contributor

@blankse blankse commented Apr 21, 2024

Alternative to #16689

@github-actions GitHub Actions
Copy link

Review Checklist

  • Target branch (11.2 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@blankse blankse mentioned this pull request Apr 21, 2024
Closed
@blankse blankse changed the base branch from 11.x to 11.2 April 21, 2024 16:42
@mattamon mattamon self-assigned this Apr 26, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

mattamon
mattamon approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@mattamon mattamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As always, thank you for your contribution it is highly welcome!
Keep up the good work! :)

@mattamon mattamon added this to the 11.2.4 milestone May 3, 2024
@mattamon mattamon merged commit e1d9916 into pimcore:11.2 May 3, 2024
17 checks passed
@blankse blankse deleted the fix_search_controller branch May 3, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattamon mattamon mattamon approved these changes

Assignees

@mattamon mattamon

Labels
Pimcore:ToDo
Projects
None yet
Milestone
11.2.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blankse @mattamon @wisconaut