Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Numeric Editable config option "decimalPrecision" does not work / is hard coded #16959

Closed
marvin-bilharz opened this issue Apr 18, 2024 · 1 comment
Labels

Comments

@marvin-bilharz
Copy link
Contributor

Pimcore version

11.2.2

Steps to reproduce

  • create a numeric editable inside a brick editable dialog
    [ 'type' => 'numeric', 'label' => 'image_count', 'name' => 'imageCount', 'config' => [ 'minValue' => 1, 'decimalPrecision' => 0 ] ]
  • go to backend, add your brick, open editable dialog and write number e.g. "1.52" inside the numeric editable it and save/close the dialog
  • reopen the dialog

Actual Behavior

After saving and reopen the number is still "1.52".

This is because the decimalPrecision option is hardcoded in vendor/pimcore/admin-ui-classic-bundle/public/js/pimcore/document/editables/numeric.js

image

Expected Behavior

After input change the number should transform to "2".
Should be an option as stated in https://pimcore.com/docs/platform/Pimcore/Documents/Editables/Numeric/#advanced-usage

@blankse
Copy link
Contributor

blankse commented Apr 22, 2024

@marvin-bilharz I created a PR: pimcore/admin-ui-classic-bundle#507

@lukmzig lukmzig closed this as completed May 3, 2024
@lukmzig lukmzig modified the milestone: 11.2.4 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants