Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: [Objects] External video preview image (YouTube) blocked due to CSP #526

Open
podarcis opened this issue Apr 9, 2024 · 5 comments · May be fixed by #527
Open

[Bug]: [Objects] External video preview image (YouTube) blocked due to CSP #526

podarcis opened this issue Apr 9, 2024 · 5 comments · May be fixed by #527

Comments

@podarcis
Copy link
Contributor

podarcis commented Apr 9, 2024

Pimcore version

11.2.2

Steps to reproduce

  1. Have data field of type video.
  2. Choose external video (e.g. YouTube) and paste its YT-code.
  3. Preview image is blocked by the browser due to CSP.

Refused to frame 'https://www.youtube-nocookie.com/' because it violates the following Content Security Policy directive: "frame-src 'self' data:".

Actual Behavior

Preview image is blocked due to CSP and thus not shown.

Expected Behavior

As configuring YouTube in video field is a core functionality it should not require project specific configuring such as:

pimcore_admin:
    admin_csp_header:
        additional_urls:
            frame-src:
                - 'https://www.youtube-nocookie.com/'

Instead these external video services should be allowed by default in ContentSecurityPolicyHandler.

@podarcis podarcis added the Bug label Apr 9, 2024
@podarcis
Copy link
Contributor Author

I'd do a PR in pimcore/admin-ui-classic-bundle, when you confirm/label this issue (which you might also want to transfer to pimcore/admin-ui-classic-bundle).

Copy link

github-actions bot commented May 6, 2024

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

@AlternateIf
Copy link
Contributor

can confirm this

@AlternateIf
Copy link
Contributor

            - 'https://www.dailymotion.com/'
            - 'https://player.vimeo.com/'

should also be included

@fashxp fashxp transferred this issue from pimcore/pimcore May 10, 2024
@fashxp
Copy link
Member

fashxp commented May 10, 2024

PR would be great. Thx

@podarcis podarcis linked a pull request May 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants