Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: Implement DataObject::getByKey #10710

Closed
fashxp opened this issue Oct 27, 2021 · 7 comments
Closed

[Improvement]: Implement DataObject::getByKey #10710

fashxp opened this issue Oct 27, 2021 · 7 comments
Labels
Improvement
Milestone
10.3.0

Comments

@fashxp
Copy link
Member

fashxp commented Oct 27, 2021

Improvement description

analog to all the other DataObject::getBy* methods

will solve pimcore/data-importer#104
@fashxp fashxp mentioned this issue Oct 27, 2021
Open
@danielczestki
Copy link

danielczestki commented Oct 29, 2021 •
edited

@fashxp is there a plan for add getByKey method in the near time. I need it very much :)
Is it possible to add it to 6.9 PimCore too ?

@brusch
Copy link
Member

brusch commented Oct 29, 2021

See #10712

@danielczestki
Copy link

@brusch #10712 merge is for 10.X not 6.9

@brusch
Copy link
Member

brusch commented Oct 29, 2021

@danielczestki 6.9 is end of life.

@danielczestki
Copy link

danielczestki commented Oct 29, 2021 •
edited

Yes I know but I need it in 6.9 ? What should I do then ? @brusch
Using local composer patches ? will it work with pimcore ?

@fashxp fashxp added this to the 10.3.0 milestone Feb 1, 2022
@brusch
Copy link
Member

brusch commented Feb 2, 2022

@danielczestki yes, of course that works

@brusch brusch closed this as completed Feb 2, 2022
@brusch
Copy link
Member

brusch commented Feb 2, 2022

Resolved by #10712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
10.3.0
Development

No branches or pull requests
3 participants
@brusch @danielczestki @fashxp