You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
what, if we just create two different JS files for that permission helper ... one for Pimcore 10 and one for Pimcore 11 and include them depending on the Pimcore version in use?
Or do we also have a problem when using perspectives in Pimcore 11 that where created in Pimcore 10 ?
AFAIK it would be more a visual and "cleanliness" problem, meaning that it would display "extra" stuff that might have no meaning nor effect, if the related bundle is not present/installed.
Splitting the file sounds good to me.
For the 11 specific shorter list, we may need to add a priority property to each element and add them via event, similarly to navigation's change to keep the ordering the same.
Improvement description
Potentially we need to remove these perspectives from the list or have a bc layer for 10/11?
newsletter-bundle extracted
perspective-editor/src/Resources/public/js/pimcore/perspective/menuItemPermissionHelper.js
Line 26 in 104ed6c
web-to-print-bundle
perspective-editor/src/Resources/public/js/pimcore/perspective/menuItemPermissionHelper.js
Line 29 in 104ed6c
removal of import from server
https://github.com/pimcore/perspective-editor/blob/1.x/src/Resources/public/js/pimcore/perspective/menuItemPermissionHelper.js#L55
removal of import from url
perspective-editor/src/Resources/public/js/pimcore/perspective/menuItemPermissionHelper.js
Line 56 in 104ed6c
See also [Task]: Fix docs about removal of import from server and url pimcore#15080
google-marketing-bundle
perspective-editor/src/Resources/public/js/pimcore/perspective/menuItemPermissionHelper.js
Lines 111 to 114 in 104ed6c
reports
perspective-editor/src/Resources/public/js/pimcore/perspective/menuItemPermissionHelper.js
Line 108 in 104ed6c
system-info
perspective-editor/src/Resources/public/js/pimcore/perspective/menuItemPermissionHelper.js
Lines 128 to 134 in 104ed6c
and so on...
The text was updated successfully, but these errors were encountered: