Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Follow up based on latest Pimcore 11 changes #134

Open
6 tasks
kingjia90 opened this issue May 2, 2023 · 2 comments
Open
6 tasks

[Task]: Follow up based on latest Pimcore 11 changes #134

kingjia90 opened this issue May 2, 2023 · 2 comments

Comments

@kingjia90
Copy link
Contributor

Improvement description

Potentially we need to remove these perspectives from the list or have a bc layer for 10/11?

and so on...

@fashxp
Copy link
Member

fashxp commented May 2, 2023

what, if we just create two different JS files for that permission helper ... one for Pimcore 10 and one for Pimcore 11 and include them depending on the Pimcore version in use?

Or do we also have a problem when using perspectives in Pimcore 11 that where created in Pimcore 10 ?

@kingjia90
Copy link
Contributor Author

AFAIK it would be more a visual and "cleanliness" problem, meaning that it would display "extra" stuff that might have no meaning nor effect, if the related bundle is not present/installed.
image

Splitting the file sounds good to me.
For the 11 specific shorter list, we may need to add a priority property to each element and add them via event, similarly to navigation's change to keep the ordering the same.

In other bundles, we are adding these perspective this way or so
https://github.com/pimcore/advanced-object-search/blob/d62779bf8eabb4afe299c7b3520ba04dd12f92b0/src/Resources/public/js/startup.js#L38-L48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants