Add CSRF protection for Add to cart action (#273)

* Fix CSRF protection for cart - resolves #260 * Fix CSRF protection for cart - resolves #260
pimcore · Dec 9, 2021 · 13ef643 · 13ef643
1 parent 0d7a14f
commit 13ef643
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/src/Controller/CartController.php b/src/Controller/CartController.php
@@ -54,7 +54,7 @@ protected function getCart()
     }
 
     /**
-     * @Route("/cart/add-to-cart", name="shop-add-to-cart")
+     * @Route("/cart/add-to-cart", name="shop-add-to-cart", methods={"POST"})
      *
      * @param Request $request
      * @param Factory $ecommerceFactory
@@ -65,6 +65,10 @@ protected function getCart()
      */
     public function addToCartAction(Request $request, Factory $ecommerceFactory)
     {
+        if (!$this->isCsrfTokenValid('addToCart', $request->get('_csrf_token'))) {
+            throw new \Exception('Invalid request');
+        }
+
         $id = $request->get('id');
         $product = AbstractProduct::getById($id);
 

diff --git a/templates/product/detail.html.twig b/templates/product/detail.html.twig
@@ -156,8 +156,11 @@
                                 <p class="small text-muted mt-1">{{ 'general.available-in' | trans }} {{ ('attribute.' ~ product.saleInformation.saleInformation.availabilityType) | lower | trans }}</p>
                             {% endif %}
                         </div>
-
-                        <a href="{{ path('shop-add-to-cart', { id: product.id }) }}" class="btn btn-success btn-block">{{ 'general.add-to-cart' | trans }}</a>
+                        <form id="shop_add_to_cart_form" method="post" action="{{ path('shop-add-to-cart', { id: product.id }) }}">
+                            <input type="hidden" name="_csrf_token" value="{{ csrf_token('addToCart') }}">
+                            <a href="#" onclick="document.getElementById('shop_add_to_cart_form').submit();"
+                               class="btn btn-success btn-block">{{ 'general.add-to-cart' | trans }}</a>
+                        </form>
 
                     </div>
 

diff --git a/templates/product/product_teaser.html.twig b/templates/product/product_teaser.html.twig
@@ -33,7 +33,12 @@
                         </a>
                     </div>
                     <div class="col p-1">
-                        <a href="{{ path('shop-add-to-cart', { id: product.id }) }}" class="btn btn-block btn-primary">{{ 'general.buy' | trans }} <i class=" ml-2"><img src="/static/images/icons/cart.svg" height="20" width="auto"></i></a>
+                        <form id="shop_add_to_cart_form" method="post" action="{{ path('shop-add-to-cart', { id: product.id }) }}">
+                            <input type="hidden" name="_csrf_token" value="{{ csrf_token('addToCart') }}">
+                            <a href="#" onclick="document.getElementById('shop_add_to_cart_form').submit();"
+                               class="btn btn-block btn-primary">{{ 'general.buy' | trans }} <i class=" ml-2"><img
+                                        src="/static/images/icons/cart.svg" height="20" width="auto"></i></a>
+                        </form>
                     </div>
                 </div>
             </div>