Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix explode operator to return an empty array when input is empty #403

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

aweichler
Copy link
Contributor

When the input is an empty string, the return value is an array with a "null" value: [null].
This pull request fixes this issue. An empty string results in an empty array.

src/Mapping/Operator/Simple/Explode.php Outdated Show resolved Hide resolved
@fashxp
Copy link
Member

fashxp commented Apr 17, 2024

can you also please rebase to 1.8, thank you very much.

@fashxp fashxp added the Bug label Apr 17, 2024
@fashxp fashxp added this to the 1.8.8 milestone Apr 17, 2024
@aweichler aweichler changed the base branch from 1.x to 1.8 April 17, 2024 08:42
@aweichler aweichler requested a review from fashxp April 17, 2024 08:44
Copy link
Member

@fashxp fashxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ thx very much!

@fashxp fashxp self-assigned this Apr 17, 2024
@fashxp fashxp merged commit e0436e7 into pimcore:1.8 Apr 17, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants