Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix permanent lock of sequential command, when an error occurs #402

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

aweichler
Copy link
Contributor

When an error (PHP \Error) occurs the command crashed and did not release the lock. After that it is not possible to rerun the sequential import command. This pull request fixes this issue.

@fashxp fashxp changed the base branch from 1.x to 1.8 April 17, 2024 07:23
@fashxp fashxp changed the base branch from 1.8 to 1.x April 17, 2024 07:23
@fashxp
Copy link
Member

fashxp commented Apr 17, 2024

thx very much, could you please rebase to 1.8?

@fashxp fashxp added the Bug label Apr 17, 2024
@fashxp fashxp added this to the 1.8.8 milestone Apr 17, 2024
@aweichler aweichler changed the base branch from 1.x to 1.8 April 17, 2024 07:43
@aweichler aweichler changed the base branch from 1.8 to 1.x April 17, 2024 07:43
@aweichler aweichler changed the base branch from 1.x to 1.8 April 17, 2024 07:59
@fashxp fashxp self-assigned this Apr 17, 2024
@fashxp fashxp merged commit c65f252 into pimcore:1.8 Apr 17, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants