Update SftpLoader.php #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The syntax "ElementInterface | null" is only supported since PHP 8 and breaks this bundle in Pimcore 6. Changed to ?ElementInterface.
Hello, I just intalled today again the extension and went on the problem I mentionned a few month ago pimcore#94 I think it is better to update the install documentation with this additionnal parameter so install is fluid with no problem for people trying the extension. (it tooks me some times to remember how to bypass this problem, so if it is directly on the install command on the documentation, no need to dig to find how to install it on Pimcore 10!) Thanks, Best regards
* Update 02_Transformation_Pipeline.md * fixed some typos Co-authored-by: Christian Fasching <fashxp@users.noreply.github.com>
I have read the CLA Document and I hereby sign the CLA
# Conflicts: # doc/01_Installation.md
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
…imcore#122) * [Configuration] Add more fine-grained permissions to configurations - related to pimcore/data-hub#438 * Apply php-cs-fixer changes * [Configuration] Add more fine-grained permissions to configurations - related to pimcore/data-hub#438 * [Configuration] Add more fine-grained permissions to configurations - related to pimcore/data-hub#438 * [Configuration] Add more fine-grained permissions to configurations - related to pimcore/data-hub#438 * [Installer] Proper way of marking bundle installed on upgrade * Apply php-cs-fixer changes * [Feature]: Webhooks * [Configuration] Add more fine-grained permissions to configurations * Apply suggestions from code review Co-authored-by: Sebastian Blank <blank@data-factory.net> * [Configuration] Add more fine-grained permissions to configurations * Apply php-cs-fixer changes * [Configuration] Add more fine-grained permissions to configurations * [Configuration] Add more fine-grained permissions to configurations * [Configuration] Add more fine-grained permissions to configurations - related to pimcore/data-hub#438 * Apply php-cs-fixer changes * [Configuration] Add more fine-grained permissions to configurations - related to pimcore/data-hub#438 * [Configuration] Add more fine-grained permissions to configurations - related to pimcore/data-hub#438 * [Configuration] Add more fine-grained permissions to configurations - related to pimcore/data-hub#438 * [Installer] Proper way of marking bundle installed on upgrade * Apply php-cs-fixer changes * [Configuration] Add more fine-grained permissions to configurations * Apply suggestions from code review Co-authored-by: Sebastian Blank <blank@data-factory.net> * [Configuration] Add more fine-grained permissions to configurations * Apply php-cs-fixer changes * [Configuration] Add more fine-grained permissions to configurations * [Configuration] Add more fine-grained permissions to configurations * Apply php-cs-fixer changes * [Configuration] Add more fine-grained permissions to configurations * Apply php-cs-fixer changes * [Configuration] Add more fine-grained permissions to configurations * added category for permissions and missing translations * Apply php-cs-fixer changes * fix old migration Co-authored-by: dvesh3 <dvesh3@users.noreply.github.com> Co-authored-by: mcop1 <marco.perberschlager@pimcore.com> Co-authored-by: mcop1 <89011527+mcop1@users.noreply.github.com> Co-authored-by: Sebastian Blank <blank@data-factory.net> Co-authored-by: mcop1 <mcop1@users.noreply.github.com> Co-authored-by: Christian Fasching <christian.fasching@pimcore.com> Co-authored-by: fashxp <fashxp@users.noreply.github.com>
|
@Daniel-Ateles could you please rebase to 1.3 branch as this is a bugfix. Thx. |
* Setup PhpStan Test * Switch to Doctrine Migrations * Add bootstrap file * Add missing models * Require Carbon > 1.37.0 * Option must be an int * Require doctrine migrations > 1.8 * Add stubs for wrong PhpDocs in Pimcore 6.9 * Require doctrine dbal > 2.11 * Fix stubs * Add ElementInterface.stub * Make doctrine migration yaml optional * Fix PhpDocs * Fix new errors * Require data-hub > 1.1 * Support data-hub < 1.1 for pimcore 6.9 * Only test with Pimcore X and PHP > 8 necessary now * Fix new error * Remove unnecessary stubs, Update composer.json * Revert ConfigDataObjectController.php changes * Remove test models and faker dependency, exclude DummyDataCommand from phpstan instead * Remove autoload-dev
|
@Daniel-Ateles ping :) |
Should I select "origin/1.3" or "upstream/1.3" (see screenshot) |
|
if your origin is quite up-to-date is should not matter. |
I have read the CLA Document and I hereby sign the CLA
Downloads the sftp stream to the local file and returns the file.
Daniel-Ateles
force-pushed
the
sftloader-fix-2
branch
from
6ec2b1b
to
b2e2ead
Compare
There were no changes to rebase for origin/1.3 but 12 on the upstream, so I selected upstream and solved some merge conflicts. So it should be done now. |
|
hmm, still not able to change the base to 1.3 properly. |
|
it seems, you merged 1.x somehow into that branch. It think start over again would be the easiest and fastest option. |
Ok! Will do! |
Done. I've created a PR for "sftploader-fix-3" based on 1.3. |
|
closed in favor of #155 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloads the sftp stream to the local file and returns the file.