Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: labels get lowercased #846

Open
dkarlovi opened this issue Mar 27, 2024 · 4 comments · May be fixed by #853
Open

[Bug]: labels get lowercased #846

dkarlovi opened this issue Mar 27, 2024 · 4 comments · May be fixed by #853
Labels
Bug PR Welcome
Milestone
1.7.1

Comments

@dkarlovi
Copy link

Expected behavior

The labeled field is exported exactly like the label.

Actual behavior

The labeled field is lowercased.

Steps to reproduce

  1. Create a field like so
                                -
                                    isOperator: true
                                    attributes:
                                        label: Image
                                        type: operator
                                        class: assets
                                        children:
                                            -
                                                isOperator: false
                                                attributes:
                                                    label: 'Category Image'
                                                    type: value
                                                    class: DefaultValue
                                                    attribute: image
                                                    dataType: image
                                                    children: {  }
  1. create a query like so
getProductCategoryListing {edges {node {id, Image{id, fullpath, url}}}}
  1. get error
GraphQL query failed: Cannot query field "Image" on type "object_ProductCategory". Did you mean "image" or "tags"?
  1. try with lowercase label
getProductCategoryListing {edges {node {id, image{id, fullpath, url}}}}
  1. it works like that
@dkarlovi dkarlovi added the Bug label Mar 27, 2024
@github-actions GitHub Actions
Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

@blankse blankse linked a pull request Apr 22, 2024 that will close this issue
Open
@blankse
Copy link
Contributor

blankse commented Apr 22, 2024

@dkarlovi I created a PR: #853
Can you test it?

@dkarlovi
Copy link
Author

@blankse I will test it during the day, thanks.

@dkarlovi
Copy link
Author

@blankse I can confirm this works correctly! 🚀

@fashxp fashxp added this to the 1.7.1 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug PR Welcome
Projects
None yet
Milestone
1.7.1
Development

Successfully merging a pull request may close this issue.

Fix: Labels get lowercased blankse/data-hub
3 participants
@dkarlovi @blankse @fashxp