Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable SQL condition field #830

Closed
markus-moser opened this issue Jan 24, 2024 · 0 comments · Fixed by #831
Closed

Add option to disable SQL condition field #830

markus-moser opened this issue Jan 24, 2024 · 0 comments · Fixed by #831

Comments

@markus-moser
Copy link

Improvement description

Related to #809 and #810.

The SQL condition is a potential security risk (SQL injections). Therefore there should be an option to disable it. In the next major version we then can remove it completely.

As an alternative it's possible to use the pimcore.datahub.graphql.listing.preLoadto add custom conditions. In future version we can maybe additionally add some kind of query builder.

@markus-moser markus-moser added this to the 1.7.0 milestone Jan 24, 2024
@exalate-issue-sync exalate-issue-sync bot removed this from the 1.7.0 milestone Jan 25, 2024
@lukmzig lukmzig added this to the 1.7.0 milestone Jan 25, 2024
@lukmzig lukmzig self-assigned this Jan 25, 2024
@exalate-issue-sync exalate-issue-sync bot removed this from the 1.7.0 milestone Jan 25, 2024
@wisconaut wisconaut added this to the 1.7.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants