Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DI for services & remove aliases #385

Closed
wants to merge 12 commits into from
Closed

Conversation

dvesh3
Copy link
Contributor

@dvesh3 dvesh3 commented Dec 27, 2022

Resolves #205

Additional Info

  • Use Dependency Injection for services (make services private by default)
  • Remove service aliases

TODO

  • Add upgrade notes
  • Add removed alias back for BC

@markus-moser
Copy link
Contributor

Let's close this as it is to outdated. If we really want to do this we need to create a new PR.

@markus-moser markus-moser deleted the save_handler_services branch April 30, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customer save handlers should support DI
2 participants