Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add video service providers to CSP allow list #527

Open
wants to merge 1 commit into
base: 1.4
Choose a base branch
from

Conversation

podarcis
Copy link
Contributor

@podarcis podarcis commented May 10, 2024

This adds the URLs of currently used video services to the CSP allow list for type frame so that video preview thumbnails are shown in backend.

Before this fix the video preview thumbnails are not shown but instead following message is logged to console:
Refused to frame 'https://www.youtube-nocookie.com/' because it violates the following Content Security Policy directive: "frame-src 'self' data:".

Fixes #526

@robertSt7
Copy link
Contributor

@podarcis The target branch for bug fixes should be 1.4. Could you please change that? Thanks

This adds the URLs of currently used video services to the CSP allow list for
type frame so that video preview thumbnails are shown in backend.

Before this fix the video preview thumbnails are not shown but instead
following message is logged to console:
`Refused to frame 'https://www.youtube-nocookie.com/' because it violates the
following Content Security Policy directive: "frame-src 'self' data:".`
@podarcis podarcis force-pushed the bugfix/csp-video-thumbnail branch from f512fe9 to d2ef8fa Compare May 17, 2024 08:55
@podarcis podarcis changed the base branch from 1.x to 1.4 May 17, 2024 08:55
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: [Objects] External video preview image (YouTube) blocked due to CSP
3 participants