Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement, EC]: Display read-only asset metadata when granted view permission #435

Closed
wisconaut opened this issue Feb 15, 2024 · 1 comment · Fixed by #524
Closed

[Improvement, EC]: Display read-only asset metadata when granted view permission #435

wisconaut opened this issue Feb 15, 2024 · 1 comment · Fixed by #524
Assignees
@kingjia90
Labels
Improvement Pimcore:Priority
Milestone
1.5.0

Comments

@wisconaut
Copy link
Contributor

wisconaut commented Feb 15, 2024 •
edited by fashxp

Pimcore version

11.x

Actual Behavior

In the backoffice, the asset metadata tab disappears when either the workflow state disallows editing (modify, save, publish, unpublish, delete, rename false) or a user is lacking publish rights, so the meta data can not be read.
The metadata is only visible when it is editable.

Expected Behavior

The metadata should be visible by correct rights.
@kingjia90
Copy link
Contributor

Moving to admin-ui-classic-bundle, seems fine but could provide a read-only for view permissions

admin-ui-classic-bundle/public/js/pimcore/asset/image.js

Lines 76 to 78 in 7cf5e12

if (this.isAllowed("publish")) {
items.push(this.metadata.getLayout());
}

See also https://pimcore.atlassian.net/browse/PEES-243?focusedCommentId=20220

@kingjia90 kingjia90 transferred this issue from pimcore/pimcore Feb 20, 2024
@kingjia90 kingjia90 mentioned this issue Feb 20, 2024
Closed
@kingjia90 kingjia90 changed the title [BUG, EC]: Asset Metadata - either editable or invisible + publish rights necessary [Improvement, EC]: Display read-only asset metadata when granted view permission Mar 7, 2024
@wisconaut wisconaut added this to the 1.5.0 milestone Mar 8, 2024
@kingjia90 kingjia90 mentioned this issue May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kingjia90 kingjia90

Labels
Improvement Pimcore:Priority
Projects
None yet
Milestone
1.5.0
3 participants
@kingjia90 @fashxp @wisconaut