Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement - No case sensitive and wildcard usage in filter grid view #6954

Open
Hbitvof opened this issue Aug 15, 2020 · 7 comments · May be fixed by pimcore/admin-ui-classic-bundle#389
Open

Comments

@Hbitvof
Copy link

Hbitvof commented Aug 15, 2020

Hi,

At the moment when using a filter in an input column this is case sensitive so you have to search for exact term.
This is not very user friendly. Can this be changed?

Also using wildcards are not working in this filter like *. Can this also be added?

@Hbitvof
Copy link
Author

Hbitvof commented Sep 14, 2020

Hi,

Any comment on this suggestion?

@Hbitvof
Copy link
Author

Hbitvof commented Nov 29, 2020

Still no one reacting?

@jdreesen
Copy link
Contributor

I'm sure the Pimcore team will gladly merge your PRs that implement the requested feature.

@stale
Copy link

stale bot commented Mar 14, 2022

Thanks a lot for reporting the issue. The issue was not considered by us as "Priority" or "Backlog", so we're not gonna work on that anytime soon. In case this is a bug report, please create a pull request fixing the issue, we'll then review it as soon as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request, we'll then decide whether we'd accept it or not. Thanks for your understanding.

@stale stale bot added the PR Welcome label Mar 14, 2022
@robin-ntriga
Copy link

I managed to fix the case sensitivity issue in: vendor/pimcore/pimcore/bundles/AdminBundle/Helper/GridHelperService.php

By adding lower() around the column names & values:

GridHelperService.php:331
$conditionPartsFilters[] = 'concat(lower(o_path), lower(o_key)) ' . $operator . ' lower(' . $db->quote('%' . $filter['value'] . '%') . ')';

GridHelperService.php:334
$conditionPartsFilters[] = 'lower(o_key) ' . $operator . ' lower(' . $db->quote('%' . $filter['value'] . '%') . ')';

Is this change correct? If so I will make a PR with the fix.

@fashxp
Copy link
Member

fashxp commented Dec 19, 2023

can you still create a PR for that?

@robin-ntriga
Copy link

I have created a PR to fix the case sensitivity issue:
pimcore/admin-ui-classic-bundle#389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants