Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Path formatter for many-to-one relation when using inline search as display mode #321

Open
limenet opened this issue Oct 25, 2023 · 1 comment

Comments

@limenet
Copy link
Contributor

limenet commented Oct 25, 2023

For many-to-one relations in objects, a formatter service (implementing \Pimcore\Model\DataObject\ClassDefinition\PathFormatterInterface) can be specified which is used to format the displayed path. With Pimcore 11, the display type can be changed from "Display path reference" to "Inline search". This feature is very helpful to create dropdown-like relations.

The formatting of the path is done via a GET to /admin/element/get-nice-path. This route is called for both "display path reference" (aka grid) and "inline search" (aka combo) and hence a formatted path is returned for both display modes.

In the case of combo, however, the formatted path not used in pimcore.object.tags.manyToOneRelation.requestNicePathData.

Are there any plans to add support and/or is a pull request welcome? And is there a reason this was implemented like this in the first place?

Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants