Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to close GPIO menu after click #1312

Closed
markfrancisonly opened this issue Apr 27, 2024 · 2 comments
Closed

Option to close GPIO menu after click #1312

markfrancisonly opened this issue Apr 27, 2024 · 2 comments
Assignees
Labels
resolution:fixed Fixed type:feature New feature or request

Comments

@markfrancisonly
Copy link

Describe the bug

GPIO menu stays open after clicking menu item. Running a frequently used GPIO command now requires three clicks: 1) Open the GPIO menu, 2) Click to select an item, and 3) Click away to close menu ( 50% greater click burden (and I have bad hands ... )

Expected behavior:

  • Auto close GPIO menu after item selection, same as other menus, unless otherwise specified.

Related enhancement idea for further improvement

  • Enable top-level GPIO items that are displayed fulltime and only require require a single click. Would be great to have PC channel selection top-level menu items, or other cmds. I frequently use a CTRL-ALT-DEL cmd, much more often than say Macros, currently three clicks away ...
echo -ne "\x5\0\x4c\0\0\0\0\0" > /dev/kvmd-hid-keyboard
echo -ne "\0\0\0\0\0\0\0\0" > /dev/kvmd-hid-keyboard

Desktop (please complete the following information):

  • Browser: chrome 124

PiKVM info:

  • kvmd 3.333-1

Config

kvmd: 
    gpio:
        drivers:
            reboot:
                type: cmd
                cmd: [/usr/bin/sudo, reboot]
            restart_kvmd:
                type: cmd
                cmd: [/usr/bin/sudo, systemctl, restart, kvmd] 
            switch_input_ch1:
                type: cmd
                cmd: [/usr/bin/bash, /etc/kvmd/scripts/switch_input.sh, 1]
            switch_input_ch2:
                type: cmd
                cmd: [/usr/bin/bash, /etc/kvmd/scripts/switch_input.sh, 2]
            switch_input_ch3:
                type: cmd
                cmd: [/usr/bin/bash, /etc/kvmd/scripts/switch_input.sh, 3]
            switch_input_ch4:
                type: cmd
                cmd: [/usr/bin/bash, /etc/kvmd/scripts/switch_input.sh, 4]
       scheme:
            reboot_button:
                driver: reboot
                mode: output
                switch: false
            restart_kvmd_button:
                driver: restart_kvmd
                mode: output
                switch: false
            ch1_button:
                driver: switch_input_ch1
                mode: output
                switch: false
            ch2_button:
                driver: switch_input_ch2
                mode: output
                switch: false
            ch3_button:
                driver: switch_input_ch3
                mode: output
                switch: false
            ch4_button:
                driver: switch_input_ch4
                mode: output
                switch: false
       view:
            header:
                title: Controls
            table:
                - ["#PC Input"]
                - ["ch1_button|\U0001F4BB computer 1"]
                - ["ch2_button|\U0001F4BB computer 2"]
                - ["ch3_button|\U0001F4BB computer 3"]
                - ["ch4_button|\U0001F4BB computer 4"]
                - ["#PiKVM"]
                - ["reboot_button|confirm|\U0001F503 reboot", "restart_kvmd_button|confirm|restart kvmd"]

@mdevaev
Copy link
Member

mdevaev commented May 1, 2024

Hello. I did not assume that the menu should close, so everything works as intended. I think I can add some kind of option for that.

@mdevaev mdevaev added the type:feature New feature or request label May 1, 2024
@mdevaev mdevaev self-assigned this May 1, 2024
@mdevaev mdevaev changed the title GPIO menu not auto closed O May 1, 2024
@mdevaev mdevaev changed the title O Option to close GPIO menu after click May 1, 2024
mdevaev added a commit to pikvm/kvmd that referenced this issue May 12, 2024
@mdevaev
Copy link
Member

mdevaev commented May 12, 2024

Released in KVMD 4.0. Use something like ch1_button|hide|\U0001F4BB computer 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:fixed Fixed type:feature New feature or request
Development

No branches or pull requests

2 participants