[#578] Add binding for AcroFormDocumentHelper::setFormFieldName method #580
Conversation
| py::arg("q") | ||
| ) | ||
| .def( | ||
| "set_form_field_name", |
There was a problem hiding this comment.
For this to be useful to anyone who say, wants to know what form fields are present before changing their names, you'll need to bind QPDFFormFieldObjectHelper as well. Then one should be able to retrieve form fields from the form and manipulate the field name from there.
I'm not going to accept a PR that solves your issue alone and isn't helpful to others. It needs to be of general use. All of the methods of QPDFFormFieldObjectHelper and QPDFAcroFormDocumentHelper should be exposed. You're probably going to need them anyway.
Please bind get/set functions as def_property which is equivalent to setting a @property with a pythonic getter and setter. Then one would use form.fields[...].name = 'MyName' etc.
There was a problem hiding this comment.
I added the method getFormFields, although it is mandatory for the usage that I solve. You could simplify use it as I showed in the test.
I dont know how I should do the binding with def_property.
If I understand you would me to add it to the binding of the class QPDFFormFieldObjectHelper but the method is on the class QPDFAcroFormDocumentHelper.
Implementing all the methods would take me too much time as I'm completely a novice in python and just discovered how pybind11 works, we could merge the base that I implemented and someone could improve it in the future
| @@ -895,6 +896,18 @@ void init_object(py::module_ &m) | |||
| .def_property_readonly("obj", [](QPDFObjectHelper &poh) -> QPDFObjectHandle { | |||
| return poh.getObjectHandle(); | |||
| }); | |||
| py::class_<QPDFDocumentHelper, std::shared_ptr<QPDFDocumentHelper>>(m, "DocumentHelper"); | |||
| // .def( | |||
There was a problem hiding this comment.
Why is this commented out? It breaks existing functionality.
resolves #578