Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keys.Plus is obsolete although it is a separate key on german keyboards #2595

Open
rominator1983 opened this issue Dec 9, 2023 · 2 comments

Comments

@rominator1983
Copy link

Expected Behavior

Plus not being Obsolete.
On German keyboards the plus is a separate key next to the Enter-key which can be used without modifiers (shift, alt, control, etc.). I simply do not know how the pressing of the plus key would even have to be detected in code on a German keyboard.
At least it would be hard to know that it is a modifier key (Shift plus Equal key). But as said I do not know if that would even work.

So I would strongly suggest not to remove that Key Enum.
I would of course like to have your thoughts on that since I am quite new to Eto.

Actual Behavior

Plus is Obsolete

Steps to Reproduce the Problem

  1. Look at code

Code that Demonstrates the Problem

    //
    // Summary:
    //     The Plus '+' Key, which usually produces an '=' when pressed without shift and
    //     is beside the backspace key.
    [Obsolete("Since 2.4, Use Equal")]
    Plus = 0x55,

Specifications

  • Version: 2.8.2
  • Platform(s): Most likely all. I use Gtk.
  • Operating System(s): Ubuntu
@ManuelHu
Copy link
Contributor

The advice provided correct. Just use Key.Equal instead of Key.Plus. It is literally the same (the code from 2.8.2):

Eto/src/Eto/Forms/Key.cs

Lines 113 to 115 in d612886

/// <summary>The Plus '+' Key, which usually produces an '=' when pressed without shift and is beside the backspace key.</summary>
[Obsolete("Since 2.4, Use Equal")]
Plus = Equal,

Additionally, Keys.Equal is working for me with a German keyboard and Gtk when I press the plus key.

@Krutonium
Copy link

I'm with OP here, I own a keyboard with a dedicated + key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants